Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 21/01/18 18:29, jacopo mondi wrote: > Hi Hans, > > On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote: >> On 21/01/18 11:21, Hans Verkuil wrote: >>> On 21/01/18 10:53, jacopo mondi wrote: Hi Hans, On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 22/01/18 01:52, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote: >> On 01/19/18 13:20, Laurent Pinchart wrote: >>> On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: On 01/16/18 22:44, Jacopo Mondi wrote: > Add driver for

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Laurent Pinchart
Hi Hans, On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote: > On 01/19/18 13:20, Laurent Pinchart wrote: > > On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: > >> On 01/16/18 22:44, Jacopo Mondi wrote: > >>> Add driver for Renesas Capture Engine Unit (CEU). > >>> > >>> The

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread jacopo mondi
Hi Hans, On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote: > On 21/01/18 11:21, Hans Verkuil wrote: > > On 21/01/18 10:53, jacopo mondi wrote: > >> Hi Hans, > >> > >> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: > >>> static int ov7670_g_parm(struct v4l2_subdev *sd,

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Hans Verkuil
On 21/01/18 11:21, Hans Verkuil wrote: > On 21/01/18 10:53, jacopo mondi wrote: >> Hi Hans, >> >> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm >>> *parms) >>> { >>> struct v4l2_captureparm *cp =

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Hans Verkuil
On 21/01/18 10:53, jacopo mondi wrote: > Hi Hans, > > On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm >> *parms) >> { >> struct v4l2_captureparm *cp = >parm.capture; >> struct ov7670_info

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread jacopo mondi
Hi Hans, On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: > Some more comments: > [snip] > > +/* --- CEU Videobuf2 operations --- */ > > + > > +static void ceu_update_plane_sizes(struct v4l2_plane_pix_format *plane, > > + unsigned int bpl, unsigned int

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.15-rc8] [cannot apply to linuxtv-media/master next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.15-rc8] [cannot apply to linuxtv-media/master next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread Hans Verkuil
On 01/19/18 13:20, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: >> On 01/16/18 22:44, Jacopo Mondi wrote: >>> Add driver for Renesas Capture Engine Unit (CEU). >>> >>> The CEU interface supports capturing 'data' (YUV422) and 'images' >>>

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread Laurent Pinchart
Hi Hans, On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: > On 01/16/18 22:44, Jacopo Mondi wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > > > The CEU interface supports capturing 'data' (YUV422) and 'images' > > (NV[12|21|16|61]). > > > > This driver aims to

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread Hans Verkuil
Some more comments: On 01/16/18 22:44, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports capturing 'data' (YUV422) and 'images' > (NV[12|21|16|61]). > > This driver aims to replace the soc_camera-based sh_mobile_ceu one. > > Tested with

[PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-16 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.