Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Montag, den 10.03.2014, 20:19 +0100 schrieb Laurent Pinchart: > On Friday 07 March 2014 18:40:54 Philipp Zabel wrote: > > While we look at of_graph_get_next_endpoint(), could you explain the > > reason behind the extra reference count increase on the prev node: > > > > /* > >

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-10 Thread Laurent Pinchart
Hi Philipp, On Friday 07 March 2014 18:40:54 Philipp Zabel wrote: > Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart: > > Hi Philipp, > > > > Thank you for the patch. > > > > I've submitted a fix for the of_graph_get_next_endpoint() function, but it > > hasn't been applied yet du

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:38 +0100, Philipp Zabel wrote: > A 'return endpoint;' at the end of the (!prev) case allows to > reduce the indentation level of the (prev) case. > > Signed-off-by: Philipp Zabel Acked-by: Grant Likely > --- > drivers/of/base.c | 42 ++--

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Philipp Zabel
Hi Laurent, Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. > > I've submitted a fix for the of_graph_get_next_endpoint() function, but it > hasn't been applied yet due to the patch series that contained it needing > more > work. >

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-06 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. I've submitted a fix for the of_graph_get_next_endpoint() function, but it hasn't been applied yet due to the patch series that contained it needing more work. The patch is available at https://patchwork.linuxtv.org/patch/21946/. I can rebase it on top of

[PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-05 Thread Philipp Zabel
A 'return endpoint;' at the end of the (!prev) case allows to reduce the indentation level of the (prev) case. Signed-off-by: Philipp Zabel --- drivers/of/base.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/of/base.c b/d