Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Mauro Carvalho Chehab
Em Thu, 16 Aug 2018 11:58:09 +0200 Hans Verkuil escreveu: > >> This is set by the user when > >> calling > >> + :ref:`ioctl VIDIOC_QBUF ` and ignored by other ioctls. > > > > Shouldn't other ioctls return an error when V4L2_BUF_FLAG_REQUEST_FD is set > > ? > > Should they? I'd like to

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Hans Verkuil
On 16/08/18 11:58, Hans Verkuil wrote: >>> +On success :c:func:`poll() ` returns the number of file >>> +descriptors that have been selected (that is, file descriptors for which >>> the +``revents`` field of the respective struct :c:type:`pollfd` >>> +is non-zero). Request file descriptor set the

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Hans Verkuil
Hi Laurent, Thank you very much for your extensive review! On 15/08/18 18:14, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Tuesday, 14 August 2018 17:20:13 EEST Hans Verkuil wrote: >> +Description >> +=== >> + >> +If the media device supports :ref:`requests

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-15 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday, 14 August 2018 17:20:13 EEST Hans Verkuil wrote: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. > > Signed-off-by: Alexandre Courbot > Signed-off-by: Hans

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:13 +0200 Hans Verkuil escreveu: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. Looks ok to me. Just a minor nitpick (see below). Mental note: we'll need to push the

[PATCHv18 01/35] Documentation: v4l: document request API

2018-08-14 Thread Hans Verkuil
From: Alexandre Courbot Document the request API for V4L2 devices, and amend the documentation of system calls influenced by it. Signed-off-by: Alexandre Courbot Signed-off-by: Hans Verkuil --- .../media/uapi/mediactl/media-controller.rst | 1 + .../media/uapi/mediactl/media-funcs.rst