Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-05-03 Thread Pavel Machek
Hi! > It seems they don't compile. Hmmm. Did I do something wrong? "struct > fwnode_endpoint" seems to be only used in v4l2-fwnode.h; that can't be > right...? Next problem is missing dev_fwnode; fixed. Next problem is pavel@duo:/data/l/linux-n900$ git grep fwnode_graph_get_next_endpoint .

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-05-03 Thread Pavel Machek
Hi! > > Could you try to two patches I've applied on the ccp2 branch (I'll remove > > them if there are issues). > > > > That's compile tested for now only. > > > > I've updated the CCP2 patches here on top of the latest fwnode patches: > >

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-05-03 Thread Sakari Ailus
Hi Pavel, On 03/04/17 15:03, Sakari Ailus wrote: > Hi Pavel, > > On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: >> Hi! >> Ok, how about this one? omap3isp: add rest of CSI1 support CSI1 needs one more bit to be set up. Do just that. It is

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-05 Thread Pavel Machek
Hi! > > This will probably fail. > > > > rval = omap3isp_csi2_reset(phy->csi2); > > if (rval < 0) > > goto done; > > Could you try to two patches I've applied on the ccp2 branch (I'll remove > them if there are issues). > > That's compile

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Pavel Machek
Hi! > > > > + if (isp->phy_type == ISP_PHY_TYPE_3430) { > > > > + struct media_pad *pad; > > > > + struct v4l2_subdev *sensor; > > > > + const struct isp_ccp2_cfg *buscfg; > > > > + > > > > + pad = > > > >

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Laurent Pinchart
Hi Sakari, On Saturday 04 Mar 2017 17:39:46 Sakari Ailus wrote: > On Sat, Mar 04, 2017 at 03:03:18PM +0200, Sakari Ailus wrote: > > On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > >> > Ok, how about this one? > omap3isp: add rest of CSI1 support > > CSI1

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Sakari Ailus
On Sat, Mar 04, 2017 at 03:03:18PM +0200, Sakari Ailus wrote: > Hi Pavel, > > On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > > Hi! > > > > > > Ok, how about this one? > > > > omap3isp: add rest of CSI1 support > > > > > > > > CSI1 needs one more bit to be set up. Do just

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Sakari Ailus
Hi Pavel, On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > Hi! > > > > Ok, how about this one? > > > omap3isp: add rest of CSI1 support > > > > > > CSI1 needs one more bit to be set up. Do just that. > > > > > > It is not as straightforward as I'd like, see the comments

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-03 Thread Sakari Ailus
Hi Pavel, On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > Hi! > > > > Ok, how about this one? > > > omap3isp: add rest of CSI1 support > > > > > > CSI1 needs one more bit to be set up. Do just that. > > > > > > It is not as straightforward as I'd like, see the comments

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-02 Thread Pavel Machek
Hi! > > Ok, how about this one? > > omap3isp: add rest of CSI1 support > > > > CSI1 needs one more bit to be set up. Do just that. > > > > It is not as straightforward as I'd like, see the comments in the code > > for explanation. ... > > + if (isp->phy_type == ISP_PHY_TYPE_3430) { >

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-02 Thread Sakari Ailus
Hi Pavel, On Thu, Mar 02, 2017 at 11:16:04AM +0100, Pavel Machek wrote: > Hi! > > > > > >> +++ b/drivers/media/platform/omap3isp/ispccp2.c > > > > >> @@ -160,6 +163,33 @@ static int ccp2_if_enable(struct isp_ccp2_device > > > > >> *ccp2, u8 enable) return ret; > > > > >> > > > > >> } > > >

[PATCHv2] omap3isp: add support for CSI1 bus

2017-03-02 Thread Pavel Machek
Hi! > > > >> +++ b/drivers/media/platform/omap3isp/ispccp2.c > > > >> @@ -160,6 +163,33 @@ static int ccp2_if_enable(struct isp_ccp2_device > > > >> *ccp2, u8 enable) return ret; > > > >> > > > >>} > > > >> > > > >> + if (isp->revision == ISP_REVISION_2_0) { > > > > > > > > The