Re: [PATCHv2 3/5] pulse8-cec: new driver for the Pulse-Eight USB-CEC Adapter

2016-07-12 Thread Hans Verkuil
On 07/11/16 12:17, Lars Op den Kamp wrote: > Hi Hans, > > On 11-07-16 12:02, Hans Verkuil wrote: >> Hi Lars, >> >> On 07/11/2016 11:41 AM, Lars Op den Kamp wrote: >>> Hi Hans, >>> >>> just did a quick scan of this patch. >>> >>> The code should work on any firmware >= v2 revision 8, though older >

Re: [PATCHv2 3/5] pulse8-cec: new driver for the Pulse-Eight USB-CEC Adapter

2016-07-11 Thread Lars Op den Kamp
Hi Hans, On 11-07-16 12:02, Hans Verkuil wrote: Hi Lars, On 07/11/2016 11:41 AM, Lars Op den Kamp wrote: Hi Hans, just did a quick scan of this patch. The code should work on any firmware >= v2 revision 8, though older versions may return 0 when the build date is requested. I believe I added

Re: [PATCHv2 3/5] pulse8-cec: new driver for the Pulse-Eight USB-CEC Adapter

2016-07-11 Thread Hans Verkuil
Hi Lars, On 07/11/2016 11:41 AM, Lars Op den Kamp wrote: > Hi Hans, > > just did a quick scan of this patch. > > The code should work on any firmware >= v2 revision 8, though older > versions may return 0 when the build date is requested. I believe I > added that in v3. Might want to add a !=0

Re: [PATCHv2 3/5] pulse8-cec: new driver for the Pulse-Eight USB-CEC Adapter

2016-07-11 Thread Lars Op den Kamp
Hi Hans, just did a quick scan of this patch. The code should work on any firmware >= v2 revision 8, though older versions may return 0 when the build date is requested. I believe I added that in v3. Might want to add a !=0 check before writing to the log. The CEC adapter has an "autonomous

[PATCHv2 3/5] pulse8-cec: new driver for the Pulse-Eight USB-CEC Adapter

2016-07-11 Thread Hans Verkuil
This supports the Pulse-Eight USB-CEC Adapter. It has been tested with firmware versions 4 and 5, but it should hopefully work fine with older firmwares as well. Signed-off-by: Hans Verkuil --- Changes since v1: - Fix broken escape message offset. All codes >= 0xfd were corrupted because of th