Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-04 Thread kbuild test robot
Hi, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.7-rc1 next-20160603] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pavel-Machek/support-for-AD5820-camera-auto-f

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-04 Thread kbuild test robot
Hi, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.7-rc1 next-20160603] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pavel-Machek/support-for-AD5820-camera-auto-f

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-02 Thread Sakari Ailus
On Thu, Jun 02, 2016 at 09:27:37PM +0200, Pavel Machek wrote: > On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > > Hi Pavel, > > > > > > > > Well, it does not use any dt pro

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-02 Thread Pavel Machek
On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > Hi Pavel, > > > > > > Well, it does not use any dt properties. So there's not really much to > > > > discuss with dt people... >

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-02 Thread Sakari Ailus
On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > Hi Pavel, > > > > Well, it does not use any dt properties. So there's not really much to > > > discuss with dt people... > > > > > > Maybe "ad5820" needs to go to list of simple i2c

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-01 Thread Pavel Machek
On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > Hi Pavel, > > Well, it does not use any dt properties. So there's not really much to > > discuss with dt people... > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > but... > > It's an I2C device and it does use a reg

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-06-01 Thread Sakari Ailus
Hi Pavel, On Tue, May 31, 2016 at 11:34:37PM +0200, Pavel Machek wrote: > On Wed 2016-06-01 00:22:22, Sakari Ailus wrote: > > Hi Pavel, > > > > On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote: > > > > > > This adds support for AD5820 autofocus coil, found for example in > > > Nokia

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-05-31 Thread Pavel Machek
On Wed 2016-06-01 00:22:22, Sakari Ailus wrote: > Hi Pavel, > > On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote: > > > > This adds support for AD5820 autofocus coil, found for example in > > Nokia N900 smartphone. > > > > Signed-off-by: Pavel Machek > > The patch looks good to me

Re: [PATCHv5] support for AD5820 camera auto-focus coil

2016-05-31 Thread Sakari Ailus
Hi Pavel, On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote: > > This adds support for AD5820 autofocus coil, found for example in > Nokia N900 smartphone. > > Signed-off-by: Pavel Machek The patch looks good to me but then I came to think of a question I've missed so far: is there

[PATCHv5] support for AD5820 camera auto-focus coil

2016-05-27 Thread Pavel Machek
This adds support for AD5820 autofocus coil, found for example in Nokia N900 smartphone. Signed-off-by: Pavel Machek --- v2: simple cleanups, fix error paths, simplify probe v3: more cleanups, remove printk, add include v4: remove header file. v5: switch to devm_ , style cleanups, fixes diff -