Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-07 Thread Oldrich Jedlicka
On Monday 05 of October 2009 at 10:50:31, Aleksandr V. Piskunov wrote: > > > Basicly during the I2C operation that reads scancode, controller seems > > > to stop processing input from IR sensor, resulting a loss of keypress. > > > > > > So the solution(?) I found was to decrease the udelay in > > >

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
Hi Andy, On Sun, 04 Oct 2009 16:11:32 -0400, Andy Walls wrote: > On Sun, 2009-10-04 at 10:54 +0200, Jean Delvare wrote: > > On Sat, 03 Oct 2009 11:44:20 -0400, Andy Walls wrote: > > > /* This array should match the IVTV_HW_ defines */ > > > @@ -126,7 +131,8 @@ > > > "wm8739", > > > "vp27smpx"

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Oldrich Jedlicka
On Monday 05 of October 2009 at 00:23:47, Aleksandr V. Piskunov wrote: > On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote: > > Aleksandr and Jean, > > > > Zdrastvoitye & Bonjour, > > > > To support the AVerMedia M166's IR microcontroller in ivtv and > > ir-kbd-i2c with the new i2c binding

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Devin Heitmueller
On Mon, Oct 5, 2009 at 6:02 AM, Aleksandr V. Piskunov wrote: > Yup, also tried udelay=4, IR controller handles it without problems, > though cx25840 and xc2028 doesn't seem to like the 125 KHz frequency, > refusing to communicate. xc2028 even stopped responding, requiring a cold > reboot. The i2c

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Andy Walls
On Mon, 2009-10-05 at 10:29 +0200, Jean Delvare wrote: > On Sun, 04 Oct 2009 21:54:37 -0400, Andy Walls wrote: > > On Mon, 2009-10-05 at 01:23 +0300, Aleksandr V. Piskunov wrote: > > > > > > So question is: > > > 1) Is it ok to decrease udelay for this board? > > > > Sure, I think. It would act

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Aleksandr V. Piskunov
On Mon, Oct 05, 2009 at 11:04:02AM +0200, Jean Delvare wrote: > On Mon, 5 Oct 2009 11:50:31 +0300, Aleksandr V. Piskunov wrote: > > > Try: > > > > > > # modprobe ivtv newi2c=1 > > > > > > to see if that works first. > > > > > > > udelay=10, newi2c=0 => BAD > > udelay=10, newi2c=1 => BAD > >

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
On Mon, 5 Oct 2009 11:50:31 +0300, Aleksandr V. Piskunov wrote: > > Try: > > > > # modprobe ivtv newi2c=1 > > > > to see if that works first. > > > > udelay=10, newi2c=0 => BAD > udelay=10, newi2c=1 => BAD > udelay=5, newi2c=0 => OK > udelay=5, newi2c=1 => BAD The udelay value is only u

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Aleksandr V. Piskunov
> > Basicly during the I2C operation that reads scancode, controller seems > > to stop processing input from IR sensor, resulting a loss of keypress. > > > > So the solution(?) I found was to decrease the udelay in > > ivtv_i2c_algo_template from 10 to 5. Guess it just doubles the frequency > > of

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
On Sun, 04 Oct 2009 21:54:37 -0400, Andy Walls wrote: > On Mon, 2009-10-05 at 01:23 +0300, Aleksandr V. Piskunov wrote: > > So the solution(?) I found was to decrease the udelay in > > ivtv_i2c_algo_template from 10 to 5. Guess it just doubles the frequency > > of ivtv i2c bus or something like tha

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Andy Walls
On Mon, 2009-10-05 at 01:23 +0300, Aleksandr V. Piskunov wrote: > On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote: > > Aleksandr and Jean, > > > > Zdrastvoitye & Bonjour, > > > > To support the AVerMedia M166's IR microcontroller in ivtv and > > ir-kbd-i2c with the new i2c binding mode

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Aleksandr V. Piskunov
On Sun, Oct 04, 2009 at 04:41:01PM -0400, Andy Walls wrote: > On Sun, 2009-10-04 at 12:26 +0300, Aleksandr V. Piskunov wrote: > > On Sun, Oct 04, 2009 at 10:44:52AM +0200, Jean Delvare wrote: > > > On Sun, 4 Oct 2009 11:31:39 +0300, Aleksandr V. Piskunov wrote: > > > > Tested on 2.6.30.8, one of Ub

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Aleksandr V. Piskunov
On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote: > Aleksandr and Jean, > > Zdrastvoitye & Bonjour, > > To support the AVerMedia M166's IR microcontroller in ivtv and > ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in > > http://linuxtv.org/hg/~awalls/ivtv

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Andy Walls
On Sun, 2009-10-04 at 14:33 +0300, Aleksandr V. Piskunov wrote: > > Patch #3. > > > > > --- a/linux/drivers/media/video/ir-kbd-i2c.c Sat Oct 03 11:23:00 > > > 2009 -0400 > > > +++ b/linux/drivers/media/video/ir-kbd-i2c.c Sat Oct 03 11:27:19 > > > 2009 -0400 > > > @@ -730,6 +730,7 @@ >

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Andy Walls
On Sun, 2009-10-04 at 11:31 +0300, Aleksandr V. Piskunov wrote: > On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote: > > Aleksandr and Jean, > > > > Zdrastvoitye & Bonjour, > > > > To support the AVerMedia M166's IR microcontroller in ivtv and > > ir-kbd-i2c with the new i2c binding mode

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Andy Walls
On Sun, 2009-10-04 at 12:26 +0300, Aleksandr V. Piskunov wrote: > On Sun, Oct 04, 2009 at 10:44:52AM +0200, Jean Delvare wrote: > > On Sun, 4 Oct 2009 11:31:39 +0300, Aleksandr V. Piskunov wrote: > > > Tested on 2.6.30.8, one of Ubuntu mainline kernel builds. > > > > > > ivtv-i2c part works, ivtv_

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Andy Walls
On Sun, 2009-10-04 at 10:54 +0200, Jean Delvare wrote: > Hi Andy, > > On Sat, 03 Oct 2009 11:44:20 -0400, Andy Walls wrote: > > Aleksandr and Jean, > > Change 01/03 actually fixes a problem I inadvertantly let slip by for > > ivtv in newer kernels, because I missed it in my initial review. In >

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Aleksandr V. Piskunov
> Patch #3. > > > --- a/linux/drivers/media/video/ir-kbd-i2c.cSat Oct 03 11:23:00 > > 2009 -0400 > > +++ b/linux/drivers/media/video/ir-kbd-i2c.cSat Oct 03 11:27:19 > > 2009 -0400 > > @@ -730,6 +730,7 @@ > > { "ir_video", 0 }, > > /* IR device specific entries should be a

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Aleksandr V. Piskunov
On Sun, Oct 04, 2009 at 10:44:52AM +0200, Jean Delvare wrote: > On Sun, 4 Oct 2009 11:31:39 +0300, Aleksandr V. Piskunov wrote: > > Tested on 2.6.30.8, one of Ubuntu mainline kernel builds. > > > > ivtv-i2c part works, ivtv_i2c_new_ir() gets called, according to > > /sys/bus/i2c > > device @ 0x40

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Jean Delvare
Hi Andy, On Sat, 03 Oct 2009 11:44:20 -0400, Andy Walls wrote: > Aleksandr and Jean, > > Zdrastvoitye & Bonjour, > > To support the AVerMedia M166's IR microcontroller in ivtv and > ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in > > http://linuxtv.org/hg/~awalls/i

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Jean Delvare
On Sun, 4 Oct 2009 11:31:39 +0300, Aleksandr V. Piskunov wrote: > Tested on 2.6.30.8, one of Ubuntu mainline kernel builds. > > ivtv-i2c part works, ivtv_i2c_new_ir() gets called, according to /sys/bus/i2c > device @ 0x40 gets a name ir_rx_em78p153s_ave. > > Now according to my (very) limited und

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Aleksandr V. Piskunov
On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote: > Aleksandr and Jean, > > Zdrastvoitye & Bonjour, > > To support the AVerMedia M166's IR microcontroller in ivtv and > ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in > > http://linuxtv.org/hg/~awalls/ivtv

[REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-03 Thread Andy Walls
Aleksandr and Jean, Zdrastvoitye & Bonjour, To support the AVerMedia M166's IR microcontroller in ivtv and ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in http://linuxtv.org/hg/~awalls/ivtv 01/03: ivtv: Defer legacy I2C IR probing until after setup of known I2C d