Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-20 Thread Devin Heitmueller
On Wed, Mar 20, 2013 at 3:20 PM, Hans Verkuil wrote: > I want to make a pull request for this. Can I have your Acked-by or do you > want to look at this some more? I *looked* at all the patches, and they all look fine. That said, I haven't actually installed them at all and seen if anything got

Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-20 Thread Hans Verkuil
On Tue March 12 2013 03:05:50 Devin Heitmueller wrote: > On Mon, Mar 11, 2013 at 5:00 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The driver crashed when the device was disconnected while an application > > still had a device node open. Fixed by using the release() callback of > > str

Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-11 Thread Devin Heitmueller
On Mon, Mar 11, 2013 at 5:00 PM, Hans Verkuil wrote: > From: Hans Verkuil > > The driver crashed when the device was disconnected while an application > still had a device node open. Fixed by using the release() callback of struct > v4l2_device. This is all obviously good stuff. I actually spen

[REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-11 Thread Hans Verkuil
From: Hans Verkuil The driver crashed when the device was disconnected while an application still had a device node open. Fixed by using the release() callback of struct v4l2_device. Signed-off-by: Hans Verkuil --- drivers/media/usb/au0828/au0828-core.c | 48 ---