Re: [REVIEWv3 PATCH 06/17] vb2: call buf_finish from __queue_cancel.

2014-03-03 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 28 February 2014 18:42:04 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com If a queue was canceled, then the buf_finish op was never called for the pending buffers. So add this call to queue_cancel. Before calling buf_finish set the

Re: [REVIEWv3 PATCH 06/17] vb2: call buf_finish from __queue_cancel.

2014-03-02 Thread Sakari Ailus
On Fri, Feb 28, 2014 at 06:42:04PM +0100, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com If a queue was canceled, then the buf_finish op was never called for the pending buffers. So add this call to queue_cancel. Before calling buf_finish set the buffer state to PREPARED,

Re: [REVIEWv3 PATCH 06/17] vb2: call buf_finish from __queue_cancel.

2014-03-02 Thread Sakari Ailus
On Mon, Mar 03, 2014 at 08:28:05AM +0200, Sakari Ailus wrote: On Fri, Feb 28, 2014 at 06:42:04PM +0100, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com If a queue was canceled, then the buf_finish op was never called for the pending buffers. So add this call to

[REVIEWv3 PATCH 06/17] vb2: call buf_finish from __queue_cancel.

2014-02-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com If a queue was canceled, then the buf_finish op was never called for the pending buffers. So add this call to queue_cancel. Before calling buf_finish set the buffer state to PREPARED, which is the correct state. That way the states DONE and ERROR will