Re: [REVIEWv3 PATCH 13/17] vb2: replace BUG by WARN_ON

2014-03-02 Thread Sakari Ailus
On Fri, Feb 28, 2014 at 06:42:11PM +0100, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com No need to oops for this, WARN_ON is good enough. Signed-off-by: Hans Verkuil hans.verk...@cisco.com I agree; BUG() is better for something that's always (or almost so) executed.

[REVIEWv3 PATCH 13/17] vb2: replace BUG by WARN_ON

2014-02-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com No need to oops for this, WARN_ON is good enough. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git