Re: [REVIEWv7 PATCH 02/12] vb2: replace 'write' by 'dma_dir'

2014-11-26 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday 18 November 2014 13:50:58 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The 'write' argument is very ambiguous. I first assumed that if it is 1, then we're doing video output but instead it meant the reverse. Since it is used

[REVIEWv7 PATCH 02/12] vb2: replace 'write' by 'dma_dir'

2014-11-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The 'write' argument is very ambiguous. I first assumed that if it is 1, then we're doing video output but instead it meant the reverse. Since it is used to setup the dma_dir value anyway it is now replaced by the correct dma_dir value which is