Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2015-01-15 Thread Akihiro TSUKADA
Moikka, thank you for the comment. On 2015年01月14日 03:54, Antti Palosaari wrote: --- a/drivers/media/dvb-core/dvb_frontend.h +++ b/drivers/media/dvb-core/dvb_frontend.h @@ -415,6 +415,7 @@ struct dtv_frontend_properties { struct dvb_frontend { struct dvb_frontend_ops ops;

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2015-01-13 Thread Antti Palosaari
On 12/05/2014 12:49 PM, tsk...@gmail.com wrote: From: Akihiro Tsukada tsk...@gmail.com Define a standard interface for demod/tuner i2c driver modules. A module client calls dvb_i2c_attach_{fe,tuner}(), and a module driver defines struct dvb_i2c_module_param and calls DEFINE_DVB_I2C_MODULE()

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2015-01-05 Thread Akihiro TSUKADA
Hi, thank you for the comment. I understood the naming conventions you mentioned, and I'll update them in the next version. diff --git a/drivers/media/dvb-core/dvb_i2c.c b/drivers/media/dvb-core/dvb_i2c.c new file mode 100644 index 000..4ea4e5e --- /dev/null +++

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2015-01-05 Thread Akihiro TSUKADA
The only thing I noticed is that it is causing some warnings at dmesg about trying to create already created sysfs nodes, when the driver is removed/reinserted. Probably, the remove callback is called too soon or too late. I don't have any warnings in syslog when reinserting earth-pt3 +

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2015-01-05 Thread Mauro Carvalho Chehab
Em Mon, 05 Jan 2015 21:14:42 +0900 Akihiro TSUKADA tsk...@gmail.com escreveu: The only thing I noticed is that it is causing some warnings at dmesg about trying to create already created sysfs nodes, when the driver is removed/reinserted. Probably, the remove callback is called too

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2014-12-30 Thread Mauro Carvalho Chehab
Em Fri, 05 Dec 2014 19:49:33 +0900 tsk...@gmail.com escreveu: From: Akihiro Tsukada tsk...@gmail.com Define a standard interface for demod/tuner i2c driver modules. A module client calls dvb_i2c_attach_{fe,tuner}(), and a module driver defines struct dvb_i2c_module_param and calls

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2014-12-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Dec 2014 11:10:51 -0200 Mauro Carvalho Chehab mche...@osg.samsung.com escreveu: Em Fri, 05 Dec 2014 19:49:33 +0900 tsk...@gmail.com escreveu: From: Akihiro Tsukada tsk...@gmail.com Define a standard interface for demod/tuner i2c driver modules. A module client calls

Re: [RFC/PATCH] dvb-core: add template code for i2c binding model

2014-12-26 Thread Akihiro TSUKADA
ping. we don't need this kind of feature in the dvb-core? -- akihiro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC/PATCH] dvb-core: add template code for i2c binding model

2014-12-05 Thread tskd08
From: Akihiro Tsukada tsk...@gmail.com Define a standard interface for demod/tuner i2c driver modules. A module client calls dvb_i2c_attach_{fe,tuner}(), and a module driver defines struct dvb_i2c_module_param and calls DEFINE_DVB_I2C_MODULE() macro. This template provides implicit module