Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-02 Thread Ezequiel Garcia
On Sat, Jun 2, 2012 at 12:32 PM, Ezequiel Garcia wrote: > This driver adds support for stk1160 usb bridge as used in some > video/audio usb capture devices. > It is a complete rewrite of staging/media/easycap driver and > it's expected as a future replacement. > > Signed-off-by: Ezequiel Garcia >

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-03 Thread Hans Verkuil
Hi Ezequiel! On Sat June 2 2012 17:37:28 Ezequiel Garcia wrote: > On Sat, Jun 2, 2012 at 12:32 PM, Ezequiel Garcia > wrote: > > This driver adds support for stk1160 usb bridge as used in some > > video/audio usb capture devices. > > It is a complete rewrite of staging/media/easycap driver and >

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-03 Thread Ezequiel Garcia
Hi Hans, On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil wrote: [snip] > Thanks. I've fixed several things reported by v4l2-compliance (see my patch > below), but you are using an older v4l2-compliance version. You should clone > and compile the v4l-utils.git repository yourself, rather than using a

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-03 Thread Ezequiel Garcia
Hans, On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil wrote: > > Thanks. I've fixed several things reported by v4l2-compliance (see my patch > below), but you are using an older v4l2-compliance version. You should clone > and compile the v4l-utils.git repository yourself, rather than using a distro

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-04 Thread Hans Verkuil
On Sun June 3 2012 23:44:03 Ezequiel Garcia wrote: > Hans, > > On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil wrote: > > > > Thanks. I've fixed several things reported by v4l2-compliance (see my patch > > below), but you are using an older v4l2-compliance version. You should clone > > and compile t

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-04 Thread Ezequiel Garcia
On Mon, Jun 4, 2012 at 5:47 AM, Hans Verkuil wrote: > >> Would you care to explain me this change in your patch? >> +       set_bit(V4L2_FL_USE_FH_PRIO, &dev->vdev.flags); > > See Documentation/video4linux/v4l2-framework.txt: > > "flags: optional. Set to V4L2_FL_USE_FH_PRIO if you want to let the

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-04 Thread Hans Verkuil
On Mon June 4 2012 21:50:46 Ezequiel Garcia wrote: > On Mon, Jun 4, 2012 at 5:47 AM, Hans Verkuil wrote: > > > >> Would you care to explain me this change in your patch? > >> + set_bit(V4L2_FL_USE_FH_PRIO, &dev->vdev.flags); > > > > See Documentation/video4linux/v4l2-framework.txt: > > > > "