Re: [RFC][PATCH] mn88472: add support for the mn88473 demod

2014-12-30 Thread Benjamin Larsson
On 12/21/2014 10:21 AM, Antti Palosaari wrote: Moikka! [...] You patch looks rather good and these drivers should be merged to one if possible, lets say registers are 80% same or something like that. Looks like those are. I've dropped this effort, the chips registers are not similar

Re: [RFC][PATCH] mn88472: add support for the mn88473 demod

2014-12-21 Thread Antti Palosaari
Moikka! On 12/21/2014 02:06 AM, Benjamin Larsson wrote: This is what mn88473 support in the mn88472 demod driver could look like. The code is untested but will look similar in the final version. It is also possible to let the driver figure out the demod version from the 0xff register. Then the

[RFC][PATCH] mn88472: add support for the mn88473 demod

2014-12-20 Thread Benjamin Larsson
Factor out the bw_val data to a table and load data from it depending on the configured demod. Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/media/dvb-frontends/mn88472.h| 30 + drivers/staging/media/mn88472/mn88472.c | 66 ++--

Re: [RFC][PATCH] mn88472: add support for the mn88473 demod

2014-12-20 Thread Benjamin Larsson
This is what mn88473 support in the mn88472 demod driver could look like. The code is untested but will look similar in the final version. It is also possible to let the driver figure out the demod version from the 0xff register. Then the users would not need to set that parameter. Same goes