Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-07 Thread Hans Verkuil
On Wednesday, July 06, 2011 21:39:46 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2011 08:33, Hans Verkuil escreveu: On Wednesday, July 06, 2011 21:39:46 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-07 Thread Hans Verkuil
On Thursday, July 07, 2011 15:52:53 Mauro Carvalho Chehab wrote: Em 07-07-2011 08:33, Hans Verkuil escreveu: On Wednesday, July 06, 2011 21:39:46 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2011 11:58, Hans Verkuil escreveu: On Thursday, July 07, 2011 15:52:53 Mauro Carvalho Chehab wrote: Em 07-07-2011 08:33, Hans Verkuil escreveu: On Wednesday, July 06, 2011 21:39:46 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-07 Thread Tomasz Stanislawski
Hi Mauro, Hans, I am really surprised by the havoc caused by the little 2-line patch. Let me sum up what I (don't) like in Hans' and Mauro's approaches: Hans approach: - extend v4l2_enum_dv_preset with fps and flags fields, - allow enumerating presets by both index and preset code - add

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be clearer. The only adjustment would be to use index as the preset selection key. Anyway, it

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Hans Verkuil
Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be clearer. The only adjustment would be to use index as the preset selection key. Anyway, it is

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be clearer. The only adjustment would be to use index

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Laurent Pinchart
On Wednesday 06 July 2011 13:48:35 Mauro Carvalho Chehab wrote: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 09:03, Laurent Pinchart escreveu: On Wednesday 06 July 2011 13:48:35 Mauro Carvalho Chehab wrote: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Laurent Pinchart
On Wednesday 06 July 2011 14:09:38 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:03, Laurent Pinchart escreveu: On Wednesday 06 July 2011 13:48:35 Mauro Carvalho Chehab wrote: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Hans Verkuil
Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be clearer. The only adjustment would be to use

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 09:13, Laurent Pinchart escreveu: On Wednesday 06 July 2011 14:09:38 Mauro Carvalho Chehab wrote: Em 06-07-2011 09:03, Laurent Pinchart escreveu: On Wednesday 06 July 2011 13:48:35 Mauro Carvalho Chehab wrote: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Hans Verkuil
Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 09:56, Hans Verkuil escreveu: Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2011 09:14, Hans Verkuil escreveu: Em 06-07-2011 08:31, Hans Verkuil escreveu: Em 05-07-2011 10:20, Hans Verkuil escreveu: I failed to see what information is provided by the presets name. If this were removed from the ioctl, and fps would be added instead, the API would be

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Hans Verkuil
On Tuesday, July 05, 2011 00:47:43 Laurent Pinchart wrote: Hi Mauro, On Monday 04 July 2011 18:09:18 Mauro Carvalho Chehab wrote: [snip] 1) PRESET STANDARDS == = There are 3 specs involved with DV presets: ITU-R BT 709 and BT 1120 and CEA 861. At ITU-R

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Hans Verkuil
On Monday, July 04, 2011 18:09:18 Mauro Carvalho Chehab wrote: Em 29-06-2011 09:51, Tomasz Stanislawski escreveu: The 1080p59_94 is supported by latest Samsung SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Mauro Carvalho Chehab
Em 05-07-2011 04:26, Hans Verkuil escreveu: On Monday, July 04, 2011 18:09:18 Mauro Carvalho Chehab wrote: Em 29-06-2011 09:51, Tomasz Stanislawski escreveu: The 1080p59_94 is supported by latest Samsung SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Hans Verkuil
On Tuesday, July 05, 2011 14:08:03 Mauro Carvalho Chehab wrote: Em 05-07-2011 04:26, Hans Verkuil escreveu: On Monday, July 04, 2011 18:09:18 Mauro Carvalho Chehab wrote: Em 29-06-2011 09:51, Tomasz Stanislawski escreveu: The 1080p59_94 is supported by latest Samsung SoC. Signed-off-by:

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Andy Walls
Hans Verkuil hverk...@xs4all.nl wrote: I can work on the proposal this week for that. The only reason the fps hasn't been added yet is that I never had the time to do the research on how to represent the fps reliably for all CEA/VESA formats. Hmm, pixelclock / total_framesize should always work,

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Mauro Carvalho Chehab
Em 05-07-2011 16:02, Andy Walls escreveu: Hans Verkuil hverk...@xs4all.nl wrote: I can work on the proposal this week for that. The only reason the fps hasn't been added yet is that I never had the time to do the research on how to represent the fps reliably for all CEA/VESA formats. Hmm,

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-05 Thread Andy Walls
Mauro Carvalho Chehab mche...@redhat.com wrote: Em 05-07-2011 16:02, Andy Walls escreveu: Hans Verkuil hverk...@xs4all.nl wrote: I can work on the proposal this week for that. The only reason the fps hasn't been added yet is that I never had the time to do the research on how to represent

[RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-04 Thread Mauro Carvalho Chehab
Em 29-06-2011 09:51, Tomasz Stanislawski escreveu: The 1080p59_94 is supported by latest Samsung SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl ---

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-04 Thread Laurent Pinchart
Hi Mauro, On Monday 04 July 2011 18:09:18 Mauro Carvalho Chehab wrote: [snip] 1) PRESET STANDARDS == = There are 3 specs involved with DV presets: ITU-R BT 709 and BT 1120 and CEA 861. At ITU-R BT.709, both 60Hz and 60/1.001 Hz are equally called as 60 Hz. BT.1120

Re: [RFC] DV timings spec fixes at V4L2 API - was: [PATCH 1/8] v4l: add macro for 1080p59_54 preset

2011-07-04 Thread Mauro Carvalho Chehab
Em 04-07-2011 19:47, Laurent Pinchart escreveu: Hi Mauro, On Monday 04 July 2011 18:09:18 Mauro Carvalho Chehab wrote: [snip] 1) PRESET STANDARDS == = There are 3 specs involved with DV presets: ITU-R BT 709 and BT 1120 and CEA 861. At ITU-R BT.709, both 60Hz and