Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Laurent Pinchart
Hi Sakari, On Friday 06 January 2012 11:22:00 Sakari Ailus wrote: > Sakari Ailus wrote: > ... > > > I put it there to limit the maximum to 8 instead of 9, but 9 would be > > equally good. I'll change it. > > Or not. 8 is still the index of the last value. min is one to start the > menu from the

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Sakari Ailus
Sakari Ailus wrote: ... > I put it there to limit the maximum to 8 instead of 9, but 9 would be > equally good. I'll change it. Or not. 8 is still the index of the last value. min is one to start the menu from the second item. Would you like that to be changed to zero? -- Sakari Ailus sakari.ai

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch. Thanks for the review! > On Tuesday 20 December 2011 21:27:55 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Add an integer menu test control for the vivi driver. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/m

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-05 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:27:55 Sakari Ailus wrote: > From: Sakari Ailus > > Add an integer menu test control for the vivi driver. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/vivi.c | 21 + > 1 files changed, 21 inse

[RFC 03/17] vivi: Add an integer menu test control

2011-12-20 Thread Sakari Ailus
From: Sakari Ailus Add an integer menu test control for the vivi driver. Signed-off-by: Sakari Ailus --- drivers/media/video/vivi.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 7d754f