Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-15 Thread Frédéric Sureau
Hi Philipp, Le 22/12/2014 17:00, Philipp Zabel a écrit : The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work. Currently the only way to set the framerate is by using VIDIOC_S_PARM on the output queue. Signed-off-by: Philipp

Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-15 Thread Nicolas Dufresne
Le 2015-01-15 11:23, Frédéric Sureau a écrit : Maybe a-parm.output.capability should be set to |V4L2_CAP_TIMEPERFRAME| here. I think it is required by GStreamer V4L2 plugin. Looking at this, I think output device is indeed the right place to set this, and the capability should indeed be

Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-12 Thread Hans Verkuil
On 12/22/2014 05:00 PM, Philipp Zabel wrote: The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work. Currently the only way to set the framerate is by using VIDIOC_S_PARM on the output queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-12 Thread Hans Verkuil
On 01/12/2015 04:35 PM, Philipp Zabel wrote: Hi Hans, thank you for the comments! Am Montag, den 12.01.2015, 16:03 +0100 schrieb Hans Verkuil: On 12/22/2014 05:00 PM, Philipp Zabel wrote: The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work.

Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-01-12 Thread Philipp Zabel
Hi Hans, thank you for the comments! Am Montag, den 12.01.2015, 16:03 +0100 schrieb Hans Verkuil: On 12/22/2014 05:00 PM, Philipp Zabel wrote: The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work. Currently the only way to set the framerate is

[RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2014-12-22 Thread Philipp Zabel
The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work. Currently the only way to set the framerate is by using VIDIOC_S_PARM on the output queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda/coda-common.c | 29