Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-22 Thread David Ellingsworth
> Any conclusion about the locking fixes patch? > I don't like it, but it at least fixes the problem. You can add my ack. Acked-by: David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-22 Thread Mauro Carvalho Chehab
Em 18-10-2010 13:51, Hans Verkuil escreveu: > On Monday, October 18, 2010 16:55:40 David Ellingsworth wrote: >> OK, I see how this fixes it now.. You added the video_is_registered >> check inside v4l2_open after acquiring the device lock. So while it >> fixes that race it's rather ugly and very dif

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Mon, Oct 18, 2010 at 9:20 AM, Hans Verkuil wrote: > >> On Sun, Oct 17, 2010 at 8:52 AM, Hans Verkuil wrote: >>> On Sunday, October 17, 2010 14:26:18 Hans Verkuil wrote: - serialize the suspend and resume functions using the global lock. - do not call usb_autopm_put_interface after a

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread Hans Verkuil
On Monday, October 18, 2010 16:55:40 David Ellingsworth wrote: > OK, I see how this fixes it now.. You added the video_is_registered > check inside v4l2_open after acquiring the device lock. So while it > fixes that race it's rather ugly and very difficult to follow. In this > case, the original co

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Mon, Oct 18, 2010 at 10:35 AM, David Ellingsworth wrote: > On Mon, Oct 18, 2010 at 10:18 AM, Hans Verkuil wrote: >> >>> On Mon, Oct 18, 2010 at 9:38 AM, Hans Verkuil wrote: > On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil > wrote: >> - serialize the suspend and resume functio

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Mon, Oct 18, 2010 at 10:18 AM, Hans Verkuil wrote: > >> On Mon, Oct 18, 2010 at 9:38 AM, Hans Verkuil wrote: >>> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote: > - serialize the suspend and resume functions using the global lock. > - do not call usb_autopm_put_interfac

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread Hans Verkuil
> On Mon, Oct 18, 2010 at 9:38 AM, Hans Verkuil wrote: >> >>> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil >>> wrote: - serialize the suspend and resume functions using the global lock. - do not call usb_autopm_put_interface after a disconnect. - fix a race when disconnecting the

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Mon, Oct 18, 2010 at 9:38 AM, Hans Verkuil wrote: > >> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote: >>> - serialize the suspend and resume functions using the global lock. >>> - do not call usb_autopm_put_interface after a disconnect. >>> - fix a race when disconnecting the device. >>>

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread Hans Verkuil
> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote: >> - serialize the suspend and resume functions using the global lock. >> - do not call usb_autopm_put_interface after a disconnect. >> - fix a race when disconnecting the device. >> >> Reported-by: David Ellingsworth >> Signed-off-by: Hans

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread Hans Verkuil
> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote: >> - serialize the suspend and resume functions using the global lock. >> - do not call usb_autopm_put_interface after a disconnect. >> - fix a race when disconnecting the device. >> >> Reported-by: David Ellingsworth >> Signed-off-by: Hans

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote: > - serialize the suspend and resume functions using the global lock. > - do not call usb_autopm_put_interface after a disconnect. > - fix a race when disconnecting the device. > > Reported-by: David Ellingsworth > Signed-off-by: Hans Verkuil

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread Hans Verkuil
> On Sun, Oct 17, 2010 at 8:52 AM, Hans Verkuil wrote: >> On Sunday, October 17, 2010 14:26:18 Hans Verkuil wrote: >>> - serialize the suspend and resume functions using the global lock. >>> - do not call usb_autopm_put_interface after a disconnect. >>> - fix a race when disconnecting the device.

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-18 Thread David Ellingsworth
On Sun, Oct 17, 2010 at 8:52 AM, Hans Verkuil wrote: > On Sunday, October 17, 2010 14:26:18 Hans Verkuil wrote: >> - serialize the suspend and resume functions using the global lock. >> - do not call usb_autopm_put_interface after a disconnect. >> - fix a race when disconnecting the device. > > Re

Re: [RFC PATCH] radio-mr800: locking fixes

2010-10-17 Thread Hans Verkuil
On Sunday, October 17, 2010 14:26:18 Hans Verkuil wrote: > - serialize the suspend and resume functions using the global lock. > - do not call usb_autopm_put_interface after a disconnect. > - fix a race when disconnecting the device. Regarding autosuspend: something seems to work since the power/r

[RFC PATCH] radio-mr800: locking fixes

2010-10-17 Thread Hans Verkuil
- serialize the suspend and resume functions using the global lock. - do not call usb_autopm_put_interface after a disconnect. - fix a race when disconnecting the device. Reported-by: David Ellingsworth Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-mr800.c | 17 ++---