Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Hans Verkuil
On 11/05/2018 05:08 PM, Sylwester Nawrocki wrote: > Hi Hans, > > On 11/05/2018 02:12 PM, Hans Verkuil wrote: >> Thank you for the review. One question: have you also tested this with at >> least >> one of the affected drivers? >> >> I'd like to have at least one Tested-by line. > > I just tested

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Sylwester Nawrocki
Hi Hans, On 11/05/2018 02:12 PM, Hans Verkuil wrote: > Thank you for the review. One question: have you also tested this with at > least > one of the affected drivers? > > I'd like to have at least one Tested-by line. I just tested it now - video playback on Exynos4210 Trats2 so it covers the

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-05 Thread Hans Verkuil
Hi Sylwester, On 11/02/2018 05:16 PM, Sylwester Nawrocki wrote: > Hi Hans, > > On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> This patch series converts the last remaining drivers that use g/s_crop and >> cropcap to g/s_selection. > > Thank you for this clean u

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-11-02 Thread Sylwester Nawrocki
Hi Hans, On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. Thank you for this clean up! I remember attempting conversion of those remaining drivers to selection API

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-08 Thread Sakari Ailus
Hi Hans, On Fri, Oct 05, 2018 at 09:49:00AM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. > > The first two patches do some minor code cleanup. > > The third patch adds a new video_dev

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-05 Thread Niklas Söderlund
Hi Hans, I like this series, nice work! On 2018-10-05 09:49:00 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. > > The first two patches do some minor code cleanup. > > The third patch

[RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This patch series converts the last remaining drivers that use g/s_crop and cropcap to g/s_selection. The first two patches do some minor code cleanup. The third patch adds a new video_device flag to indicate that the driver inverts the normal usage of g/s_crop/cropcap. This