Re: [RFC PATCH 01/12] soc_camera: add control handler support

2011-01-24 Thread Hans Verkuil
On Wednesday, January 19, 2011 18:49:19 Guennadi Liakhovetski wrote: Hi Hans This is not a complete review yet, but just something that occurred to me, while looking at the result of applying all these your patches, maybe you could just explain, why I'm wrong, or this will be something to

Re: [RFC PATCH 01/12] soc_camera: add control handler support

2011-01-23 Thread Guennadi Liakhovetski
On Wed, 19 Jan 2011, Guennadi Liakhovetski wrote: @@ -963,15 +897,15 @@ static int soc_camera_probe(struct device *dev) if (icl-reset) icl-reset(icd-pdev); - ret = ici-ops-add(icd); - if (ret 0) - goto eadd; - /* Must have icd-vdev before

Re: [RFC PATCH 01/12] soc_camera: add control handler support

2011-01-19 Thread Guennadi Liakhovetski
Hi Hans This is not a complete review yet, but just something that occurred to me, while looking at the result of applying all these your patches, maybe you could just explain, why I'm wrong, or this will be something to change in the next version: On Wed, 12 Jan 2011, Hans Verkuil wrote:

[RFC PATCH 01/12] soc_camera: add control handler support

2011-01-11 Thread Hans Verkuil
The soc_camera framework is switched over to use the control framework. After this patch none of the controls in subdevs or host drivers are available, until those drivers are also converted to the control framework. Signed-off-by: Hans Verkuil hverk...@xs4all.nl ---