Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-13 Thread Hans Verkuil
On 06/13/17 15:23, Helen Koike wrote: > Hi Hans, > > On 2017-06-13 03:49 AM, Hans Verkuil wrote: >> On 06/12/2017 10:35 PM, Helen Koike wrote: >>> Hi Hans, >>> >>> Thank you for your review. Please check my comments below >>> >>> On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-13 Thread Helen Koike
Hi Hans, On 2017-06-13 03:49 AM, Hans Verkuil wrote: On 06/12/2017 10:35 PM, Helen Koike wrote: Hi Hans, Thank you for your review. Please check my comments below On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: +static struct component_match

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-13 Thread Hans Verkuil
On 06/12/2017 10:35 PM, Helen Koike wrote: Hi Hans, Thank you for your review. Please check my comments below On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: +static struct component_match *vimc_add_subdevs(struct vimc_device *vimc) +{ +struct

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-12 Thread Helen Koike
Hi Hans, Thank you for your review. Please check my comments below On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: Change the core structure for adding subdevices in the topology. Instead of calling the specific create function for each subdevice, inject

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-12 Thread Hans Verkuil
On 06/03/2017 04:58 AM, Helen Koike wrote: Change the core structure for adding subdevices in the topology. Instead of calling the specific create function for each subdevice, inject a child platform_device with the driver's name. Each type of node in the topology (sensor, capture, debayer,

[RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

2017-06-02 Thread Helen Koike
Change the core structure for adding subdevices in the topology. Instead of calling the specific create function for each subdevice, inject a child platform_device with the driver's name. Each type of node in the topology (sensor, capture, debayer, scaler) will register a platform_driver with the