Re: [RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-13 Thread Sangwook Lee
Hi Francesco On 12 September 2012 19:07, Francesco Lavra wrote: > Hi Sangwook, > two remarks from my review on September 9th haven't been addressed. Thanks for the review. I missed those, please let me correct them and send patch again. Regards Sangwook > I believe those remarks are correct,

Re: [RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-12 Thread Francesco Lavra
Hi Sangwook, two remarks from my review on September 9th haven't been addressed. I believe those remarks are correct, but please let me know if I'm missing something. See below. On 09/12/2012 01:26 PM, Sangwook Lee wrote: > +static int s5k4ecgx_s_power(struct v4l2_subdev *sd, int on) > +{ > +

[RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-12 Thread Sangwook Lee
This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/bri