Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-17 Thread Arun Kumar K
Hi Sylwester, On Wed, Jul 17, 2013 at 7:44 PM, Sylwester Nawrocki wrote: > On 07/17/2013 06:55 AM, Arun Kumar K wrote: >> On Wed, Jul 17, 2013 at 3:33 AM, Sylwester Nawrocki >> wrote: >>> On 07/09/2013 02:04 PM, Arun Kumar K wrote: On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote:

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-17 Thread Sylwester Nawrocki
On 07/17/2013 06:55 AM, Arun Kumar K wrote: > On Wed, Jul 17, 2013 at 3:33 AM, Sylwester Nawrocki > wrote: >> On 07/09/2013 02:04 PM, Arun Kumar K wrote: >>> >>> On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: On Fri May 31 2013 15:03:23 Arun Kumar K wrote: > > FIMC-IS use

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-16 Thread Arun Kumar K
Hi Sylwester, On Wed, Jul 17, 2013 at 3:33 AM, Sylwester Nawrocki wrote: > Hi Arun, > > > On 07/09/2013 02:04 PM, Arun Kumar K wrote: >> >> On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: >>> >>> On Fri May 31 2013 15:03:23 Arun Kumar K wrote: FIMC-IS uses certain sensors which

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-16 Thread Sylwester Nawrocki
Hi Arun, On 07/09/2013 02:04 PM, Arun Kumar K wrote: On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: On Fri May 31 2013 15:03:23 Arun Kumar K wrote: FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sens

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-09 Thread Arun Kumar K
Hi Hans, Thanks for the review. On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: > On Fri May 31 2013 15:03:23 Arun Kumar K wrote: >> FIMC-IS uses certain sensors which are exclusively controlled >> from the IS firmware. This patch adds the sensor subdev for the >> fimc-is sensors. >> >> Si

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-09 Thread Arun Kumar K
Hi Sylwester, Thank you for the review. On Fri, Jun 21, 2013 at 4:34 AM, Sylwester Nawrocki wrote: > On 05/31/2013 03:03 PM, Arun Kumar K wrote: >> >> FIMC-IS uses certain sensors which are exclusively controlled >> from the IS firmware. This patch adds the sensor subdev for the >> fimc-is senso

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-06-26 Thread Hans Verkuil
On Fri May 31 2013 15:03:23 Arun Kumar K wrote: > FIMC-IS uses certain sensors which are exclusively controlled > from the IS firmware. This patch adds the sensor subdev for the > fimc-is sensors. > > Signed-off-by: Arun Kumar K > Signed-off-by: Kilyeon Im Not surprisingly I really hate the ide

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-06-20 Thread Sylwester Nawrocki
On 05/31/2013 03:03 PM, Arun Kumar K wrote: FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sensors. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im --- drivers/media/platform/exynos5-is/fimc-is-sensor.

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-06-07 Thread Arun Kumar K
Hi Sachin, >> + if (ret < 0) { >> + pr_err("Pipeline already opened.\n"); >> + return -EBUSY; > > why not propogate 'ret'? Same for other instances below. > Yes it can be done. Will change it. Regards Arun -- To unsubscribe from this list

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-06-05 Thread Sachin Kamat
On 31 May 2013 18:33, Arun Kumar K wrote: > FIMC-IS uses certain sensors which are exclusively controlled > from the IS firmware. This patch adds the sensor subdev for the > fimc-is sensors. > > Signed-off-by: Arun Kumar K > Signed-off-by: Kilyeon Im > --- > drivers/media/platform/exynos5-is/fi

[RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-05-31 Thread Arun Kumar K
FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sensors. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im --- drivers/media/platform/exynos5-is/fimc-is-sensor.c | 463 drivers/media/