Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-05 Thread Sylwester Nawrocki
Hi Arun, On 08/05/2013 12:06 PM, Arun Kumar K wrote: > Hi Sylwester, > > Thank you for the review. > Will address all your review comments. > Some responses below: Thanks, it took me a while to review this nearly 10k of code. But fortunately I could spent some more time at the computer this week

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-05 Thread Arun Kumar K
Hi Sachin, Thank you for the review. On Mon, Aug 5, 2013 at 10:51 AM, Sachin Kamat wrote: > On 2 August 2013 20:32, Arun Kumar K wrote: >> From: Shaik Ameer Basha >> >> This patch adds support for media device for EXYNOS5 SoCs. >> The current media device supports the following ips to connect

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-05 Thread Arun Kumar K
Hi Sylwester, Thank you for the review. Will address all your review comments. Some responses below: [snip] >> + >> +static int fimc_md_register_sensor_entities(struct fimc_md *fmd) >> +{ >> + struct device_node *of_node = fmd->pdev->dev.of_node; >> + int ret; >> + >> + /* >> +

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-04 Thread Sachin Kamat
On 2 August 2013 20:32, Arun Kumar K wrote: > From: Shaik Ameer Basha > > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > > * MIPI-CSIS > Support interconnection(subdev interf

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-03 Thread Sylwester Nawrocki
On 08/02/2013 05:02 PM, Arun Kumar K wrote: From: Shaik Ameer Basha This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. * MIPI-CSIS Support interconnection(subdev interface) between

[RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-02 Thread Arun Kumar K
From: Shaik Ameer Basha This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. * MIPI-CSIS Support interconnection(subdev interface) between devices * FIMC-LITE Support capture interfa