Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Ricardo Ribalda Delgado
Hello Laurent On Thu, Jul 16, 2015 at 10:27 AM, Laurent Pinchart wrote: > I'd argue that even just two drivers would be enough :-) Especially given that > the proposed implementation for uvcvideo is wrong. This is why we have the review process :P. I do my best, but you are the expert on your d

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/16/15 10:27, Laurent Pinchart wrote: > On Thursday 16 July 2015 10:23:03 Hans Verkuil wrote: >> On 07/16/15 10:11, Laurent Pinchart wrote: >>> On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: On 07/15/15 23:05, Laurent Pinchart wrote: > On Friday 12 June 2015 18:46:23 Ricardo Ri

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Laurent Pinchart
On Thursday 16 July 2015 10:23:03 Hans Verkuil wrote: > On 07/16/15 10:11, Laurent Pinchart wrote: > > On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: > >> On 07/15/15 23:05, Laurent Pinchart wrote: > >>> On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: > Callback needed by

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/16/15 10:11, Laurent Pinchart wrote: > Hi Hans, > > On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: >> On 07/15/15 23:05, Laurent Pinchart wrote: >>> On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Laurent Pinchart
Hi Hans, On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: > On 07/15/15 23:05, Laurent Pinchart wrote: > > On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: > >> Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not > >> use the controller framework. > >> > >>

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/15/15 23:05, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: >> Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not >> use the controller framework. >> >> Signed-off-by: Ricardo Ribalda

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-15 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: > Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not > use the controller framework. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/usb/uvc/uvc_v4l2.c | 30

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-13 Thread Hans Verkuil
Laurent, Can you review/ack this since it touches on uvc? Thanks! Hans On 06/12/2015 06:46 PM, Ricardo Ribalda Delgado wrote: > Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not > use the controller framework. > > Signed-off-by: Ricardo Ribalda Delgado > --- > d

[RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-06-12 Thread Ricardo Ribalda Delgado
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not use the controller framework. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/uvc/uvc_v4l2.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b