Re: [RFCv2 PATCH 09/14] vb2: replace 'write' by 'dma_dir'

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:58 Hans Verkuil wrote: > From: Hans Verkuil > > The 'write' argument is very ambiguous. I first assumed that if it is 1, > then we're doing video output but instead it meant the reverse. > > Since it is used to setup the dma_d

[RFCv2 PATCH 09/14] vb2: replace 'write' by 'dma_dir'

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil The 'write' argument is very ambiguous. I first assumed that if it is 1, then we're doing video output but instead it meant the reverse. Since it is used to setup the dma_dir value anyway it is now replaced by the correct dma_dir value which is unambiguous. Signed-off-by: Han