Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

2012-06-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 June 2012 12:38:54 Hans Verkuil wrote: > On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote: > > On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Since this could theoretically change the debug value while in the > > > middle of v

Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

2012-06-27 Thread Hans Verkuil
On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Since this could theoretically change the debug value while in the middle > > of v4l2-ioctl.c, we make a copy of vfd->

Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

2012-06-27 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > From: Hans Verkuil > > Since this could theoretically change the debug value while in the middle > of v4l2-ioctl.c, we make a copy of vfd->debug to ensure consistent debug > behavior. In my review of RFCv1, I

[RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

2012-06-22 Thread Hans Verkuil
From: Hans Verkuil Since this could theoretically change the debug value while in the middle of v4l2-ioctl.c, we make a copy of vfd->debug to ensure consistent debug behavior. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-dev.c | 24 drivers/media/video/