Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-07 Thread Laurent Pinchart
Hi Sakari, On Sunday 06 May 2012 21:14:02 Sakari Ailus wrote: Laurent Pinchart wrote: On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: ... The pixel format and the image size at the pad are clearly format (VIDIOC_SUBDEV_S_FMT) but the other things are related to pads but not

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-07 Thread Sakari Ailus
Hi Laurent, On Mon, May 07, 2012 at 12:44:45PM +0200, Laurent Pinchart wrote: Hi Sakari, On Sunday 06 May 2012 21:14:02 Sakari Ailus wrote: Laurent Pinchart wrote: On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: ... The pixel format and the image size at the pad are clearly

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-06 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: ... The pixel format and the image size at the pad are clearly format (VIDIOC_SUBDEV_S_FMT) but the other things are related to pads but not format. I see them different kinds of properties of pads.

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API. [snip] diff --git a/src/options.c b/src/options.c index 60cf6d5..4d9d48f 100644 --- a/src/options.c +++

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Sakari Ailus
Hi Laurent, On Sat, May 05, 2012 at 02:22:26PM +0200, Laurent Pinchart wrote: Hi Sakari, Thanks for the patch. Thanks for the review! On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API.

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Laurent Pinchart
Hi Sakari, On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: On Sat, May 05, 2012 at 02:22:26PM +0200, Laurent Pinchart wrote: On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API.

[media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-04 Thread Sakari Ailus
More flexible and extensible syntax for media-ctl which allows better usage of the selection API. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- src/main.c | 17 +--- src/options.c|9 -- src/v4l2subdev.c | 73