Re: [patch] video/saa7134: potential null dereferences in debug code

On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote: Em Sat, 22 May 2010 22:59:21 +0200 Jean Delvare kh...@linux-fr.org escreveu: I would have used (null) instead of null for consistency with lib/vsprintf.c:string(). But more importantly, I suspect that a better fix would be

Re: [patch] video/saa7134: potential null dereferences in debug code

Em Sat, 22 May 2010 22:59:21 +0200 Jean Delvare kh...@linux-fr.org escreveu: Hi Dan, On Sat, 22 May 2010 22:15:35 +0200, Dan Carpenter wrote: I modified the dprintk and i2cdprintk macros to handle null dev and ir pointers. There are two couple places that call dprintk() when dev is

[patch] video/saa7134: potential null dereferences in debug code

I modified the dprintk and i2cdprintk macros to handle null dev and ir pointers. There are two couple places that call dprintk() when dev is null. One is in get_key_msi_tvanywhere_plus() and the other is in get_key_flydvb_trio(). Signed-off-by: Dan Carpenter erro...@gmail.com diff --git

Re: [patch] video/saa7134: potential null dereferences in debug code

Hi Dan, On Sat, 22 May 2010 22:15:35 +0200, Dan Carpenter wrote: I modified the dprintk and i2cdprintk macros to handle null dev and ir pointers. There are two couple places that call dprintk() when dev is null. One is in get_key_msi_tvanywhere_plus() and the other is in