Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Ben Hutchings
On Sun, 2012-09-09 at 23:26 +0100, Sean Young wrote: > On Sun, Sep 09, 2012 at 11:31:42PM +0300, Dan Carpenter wrote: > > Several of the drivers use carrier as a divisor in their s_tx_carrier() > > functions. We should do a sanity check here like we do for > > LIRC_SET_REC_CARRIER. > > > > Signed

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Sean Young
On Sun, Sep 09, 2012 at 11:31:42PM +0300, Dan Carpenter wrote: > Several of the drivers use carrier as a divisor in their s_tx_carrier() > functions. We should do a sanity check here like we do for > LIRC_SET_REC_CARRIER. > > Signed-off-by: Dan Carpenter > --- > v2: Ben Hutchings pointed out tha

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Ben Hutchings
On Sun, 2012-09-09 at 23:01 +0200, walter harms wrote: > Hi all, > I am not sure if that is a good idea. > it should be in the hands of the driver who to use these 'val' > > some driver may need a higher value like this one: I doubt that any driver can actually work with the full range of positive

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread walter harms
Hi all, I am not sure if that is a good idea. it should be in the hands of the driver who to use these 'val' some driver may need a higher value like this one: static int iguanair_set_tx_carrier(struct rc_dev *dev, uint32_t carrier) { struct iguanair *ir = dev->priv; if (carrier <

[patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Dan Carpenter
Several of the drivers use carrier as a divisor in their s_tx_carrier() functions. We should do a sanity check here like we do for LIRC_SET_REC_CARRIER. Signed-off-by: Dan Carpenter --- v2: Ben Hutchings pointed out that my first patch was not a complete fix. diff --git a/drivers/media/rc/i