Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-03-02 Thread Pavel Machek
Hi! > > Of course the relevant sysfs group could be initialized only with > > the needed number of sync leds attributes, but still this is less > > than optimal design. > > > > It looks like this interface indeed doesn't fit for sysfs. > > > > I am leaning towards removing the support for synchr

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-03-02 Thread Jacek Anaszewski
On 03/02/2015 01:54 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Feb 27, 2015 at 03:34:22PM +0100, Jacek Anaszewski wrote: Hi Sakari, On 02/21/2015 11:57 AM, Sakari Ailus wrote: Hi Pavel and Greg, On Fri, Feb 20, 2015 at 09:57:38PM +0100, Pavel Machek wrote: On Fri 2015-02-20 07:36:16, Greg KH

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-03-02 Thread Sakari Ailus
Hi Jacek, On Fri, Feb 27, 2015 at 03:34:22PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > On 02/21/2015 11:57 AM, Sakari Ailus wrote: > >Hi Pavel and Greg, > > > >On Fri, Feb 20, 2015 at 09:57:38PM +0100, Pavel Machek wrote: > >>On Fri 2015-02-20 07:36:16, Greg KH wrote: > >>>On Fri, Feb 20, 2

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-27 Thread Jacek Anaszewski
Hi Sakari, On 02/21/2015 11:57 AM, Sakari Ailus wrote: Hi Pavel and Greg, On Fri, Feb 20, 2015 at 09:57:38PM +0100, Pavel Machek wrote: On Fri 2015-02-20 07:36:16, Greg KH wrote: On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: On 02/19/2015 10:40 PM, Greg KH wrote: On Thu,

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-21 Thread Greg KH
On Fri, Feb 20, 2015 at 05:15:10PM +0100, Jacek Anaszewski wrote: > On 02/20/2015 04:36 PM, Greg KH wrote: > >On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: > >>On 02/19/2015 10:40 PM, Greg KH wrote: > >>>On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: > On Wed,

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-21 Thread Greg KH
On Sat, Feb 21, 2015 at 12:57:33PM +0200, Sakari Ailus wrote: > Hi Pavel and Greg, > > On Fri, Feb 20, 2015 at 09:57:38PM +0100, Pavel Machek wrote: > > On Fri 2015-02-20 07:36:16, Greg KH wrote: > > > On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: > > > > On 02/19/2015 10:40 PM

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-21 Thread Sakari Ailus
Hi Pavel and Greg, On Fri, Feb 20, 2015 at 09:57:38PM +0100, Pavel Machek wrote: > On Fri 2015-02-20 07:36:16, Greg KH wrote: > > On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: > > > On 02/19/2015 10:40 PM, Greg KH wrote: > > > >On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari A

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Pavel Machek
On Fri 2015-02-20 07:36:16, Greg KH wrote: > On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: > > On 02/19/2015 10:40 PM, Greg KH wrote: > > >On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: > > >>On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: > > >>> >

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Jacek Anaszewski
On 02/20/2015 04:36 PM, Greg KH wrote: On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: On 02/19/2015 10:40 PM, Greg KH wrote: On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: On Wed 2015-02-18 17:20:

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Greg KH
On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: > On 02/19/2015 10:40 PM, Greg KH wrote: > >On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: > >>On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: > >>> > >>>On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Jacek Anaszewski
Hi Pavel, On 02/20/2015 09:16 AM, Pavel Machek wrote: Hi! +What: /sys/class/leds//available_sync_leds +Date: February 2015 +KernelVersion: 3.20 +Contact: Jacek Anaszewski +Description: read/write + Space separated list of LEDs available for flash strobe

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Pavel Machek
Hi! > +What:/sys/class/leds//available_sync_leds > +Date:February 2015 > +KernelVersion: 3.20 > +Contact: Jacek Anaszewski > +Description: read/write > + Space separated list of LEDs available for flash strobe > + synchroni

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Jacek Anaszewski
On 02/19/2015 10:40 PM, Greg KH wrote: On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: Add a documentation of LED Flash class specific sysfs attributes. Signed-off-

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Greg KH
On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: > On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: > > > > On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: > > > Add a documentation of LED Flash class specific sysfs attributes. > > > > > > Signed-off-by: Jacek Anasze

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Sakari Ailus
On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: > > On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: > > Add a documentation of LED Flash class specific sysfs attributes. > > > > Signed-off-by: Jacek Anaszewski > > Acked-by: Kyungmin Park > > Cc: Bryan Wu > > Cc: Richard Purdi

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Jacek Anaszewski
On 02/18/2015 11:47 PM, Pavel Machek wrote: On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: Add a documentation of LED Flash class specific sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie NAK-ed-by: Pavel Machek +What:

0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-18 Thread Pavel Machek
On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: > Add a documentation of LED Flash class specific sysfs attributes. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie NAK-ed-by: Pavel Machek > +What:/sys/class/leds//availabl