On Sun, Nov 20, 2011 at 08:24:29AM +0100, Jean-Francois Moine wrote:
Hi Ezequiel,
It is not a minor patch, but maybe you don't know about object
programming.
As it is defined, a gspca device _is_ a video device, as a gspca
subdriver is a gspca device, and as a video device is a device:
On Thu, Nov 17, 2011 at 11:07:16AM +0100, Jean-Francois Moine wrote:
On Wed, 16 Nov 2011 15:19:04 -0300
Ezequiel Garc??a elezegar...@gmail.com wrote:
In 'media/video/gspca/gspca.c' I really hated this cast (maybe because
I am too dumb to understand it):
gspca_dev = (struct gspca_dev
On Wed, 16 Nov 2011 15:19:04 -0300
Ezequiel García elezegar...@gmail.com wrote:
In 'media/video/gspca/gspca.c' I really hated this cast (maybe because
I am too dumb to understand it):
gspca_dev = (struct gspca_dev *) video_devdata(file);
wich is only legal because a struct video_device
On Thu, Nov 17, 2011 at 11:07:16AM +0100, Jean-Francois Moine wrote:
On Wed, 16 Nov 2011 15:19:04 -0300
Ezequiel Garc??a elezegar...@gmail.com wrote:
In 'media/video/gspca/gspca.c' I really hated this cast (maybe because
I am too dumb to understand it):
gspca_dev = (struct gspca_dev
Hi folks,
In 'media/video/gspca/gspca.c' I really hated this cast (maybe because
I am too dumb to understand it):
gspca_dev = (struct gspca_dev *) video_devdata(file);
wich is only legal because a struct video_device is the first member
of gspca_dev. IMHO, this is 'unnecesary obfuscation'.