Alexey Klimov wrote:
Hello, all
Dean, so you think that we don't need s2255 name in the beginning of
message and we doesn't need s2255_dev_err macros, right ?
As i remember pr_err is just printk with KERN_ERR..
Not at all. We must have s2255 in the beginning of the message. I
wasn't s
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
>
> Mike, Thierry an Dean,
>
> Could you please review this patch?
>
> Cheers,
> Mauro.
Alexey:
Once I understood why t
Hello, all
On Thu, 2009-01-08 at 10:13 -0200, Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
Sorry, i didn't know this procedure well enough.
> Mike, Thierry an Dean,
>
> Could you please
Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
>
> Mike, Thierry an Dean,
>
> Could you please review this patch?
>
It is OK for usbvision.
Just a note with usbvision-video, Mauro you will
Mike Isely wrote:
> Why is this change needed? (Please point me at a discussion thread, if
> you'd like...)
>
> -Mike
>
I remember this list of patches:
https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3708324
and
https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3709124
I think
Hi Alexey,
It looks fine. There's no functional changes in the s2255 driver. It
is good to get rid of the magic string "s2255". The "err to pr_err"
change is the only change I'm not sure about. I have no strong opinion
about it however.
Thanks,
Mauro Carvalho Chehab wrote:
Alexey,
Yo
Why is this change needed? (Please point me at a discussion thread, if
you'd like...)
-Mike
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> Alexey,
>
> You should get the driver maintainer's ack or at least let them know that
> you're touching on their drivers.
>
> Mike, Thierry an De
Alexey,
You should get the driver maintainer's ack or at least let them know that
you're touching on their drivers.
Mike, Thierry an Dean,
Could you please review this patch?
Cheers,
Mauro.
Forwarded message:
Date: Thu, 01 Jan 2009 11:06:08 +0300
From: Alexey Klimov
To: Mauro Carvalho Chehab
