Re: On register r/w macros/procedures of drivers/media/pci

2015-04-20 Thread Andrey Utkin
On Mon, Apr 20, 2015 at 3:45 PM, Krzysztof Hałasa wrote: > Andrey Utkin writes: > >> Please check first digit. I mean _5_864, in your post there's 6869. > > Ok, I just thought it may be a typo. I can now see 5864 is a H.264 > encoder, while 686x are simpler frame-grabbers only. > > Sorry for the

Re: On register r/w macros/procedures of drivers/media/pci

2015-04-20 Thread Krzysztof Hałasa
Andrey Utkin writes: > Please check first digit. I mean _5_864, in your post there's 6869. Ok, I just thought it may be a typo. I can now see 5864 is a H.264 encoder, while 686x are simpler frame-grabbers only. Sorry for the noise. -- Krzysztof Halasa Research Institute for Automation and Mea

Re: On register r/w macros/procedures of drivers/media/pci

2015-04-20 Thread Krzysztof Hałasa
Andrey Utkin writes: > I am starting a work on driver for techwell tw5864 media grabber&encoder. If this is tw6864 then I have a driver mostly completed. Actually I'm using tw6869 but I think this is very similar (4 channels instead of 8 and PCI instead of PCIe). I have 6864s but haven't yet tri

Re: On register r/w macros/procedures of drivers/media/pci

2015-04-20 Thread Andrey Utkin
On Mon, Apr 20, 2015 at 2:18 PM, Krzysztof Hałasa wrote: > Andrey Utkin writes: > >> I am starting a work on driver for techwell tw5864 media grabber&encoder. > > If this is tw6864 then I have a driver mostly completed. > Actually I'm using tw6869 but I think this is very similar (4 channels > in

Re: On register r/w macros/procedures of drivers/media/pci

2015-04-19 Thread Andrey Utkin
On Sun, Apr 19, 2015 at 11:28 AM, Hans Verkuil wrote: > Check the types of llmio and bbmio: > > u32 __iomem *lmmio; > u8 __iomem *bmmio; > > So the values of the pointers are the same, but the types are not. > > So 'lmmio + 1' == 'bmmio + si

Re: On register r/w macros/procedures of drivers/media/pci

2015-04-19 Thread Hans Verkuil
On 04/19/2015 09:36 AM, Andrey Utkin wrote: > I am starting a work on driver for techwell tw5864 media grabber&encoder. > I am basing on tw68 driver (mentorship, advising and testing by board > owners are appreciated). And here (and in some other > drivers/media/pci/ drivers) I see what confuses me

On register r/w macros/procedures of drivers/media/pci

2015-04-19 Thread Andrey Utkin
I am starting a work on driver for techwell tw5864 media grabber&encoder. I am basing on tw68 driver (mentorship, advising and testing by board owners are appreciated). And here (and in some other drivers/media/pci/ drivers) I see what confuses me: tw68-core.c: dev->lmmio = ioremap(pci_res