Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-31 Thread Laurent Pinchart
Hi Kamil, On Monday 30 January 2012 14:39:22 Kamil Debski wrote: On 30 January 2012 13:12 Laurent Pinchart wrote: On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for flipping the image horizontally and vertically. [snip] +

RE: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-31 Thread Kamil Debski
Hi Laurent and Sachin, From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 31 January 2012 10:30 Hi Kamil, On Monday 30 January 2012 14:39:22 Kamil Debski wrote: On 30 January 2012 13:12 Laurent Pinchart wrote: On Monday 30 January 2012 10:58:43 Sachin Kamat

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-31 Thread Sachin Kamat
Hi Kamil, Thank you for your comments. On 31 January 2012 15:39, Kamil Debski k.deb...@samsung.com wrote: Hi Laurent and Sachin, From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 31 January 2012 10:30 Hi Kamil, On Monday 30 January 2012 14:39:22 Kamil Debski wrote:

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Laurent Pinchart
Hi Sashin, Thanks for the patch. On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 +++

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sylwester Nawrocki
On 01/30/2012 01:11 PM, Laurent Pinchart wrote: static int g2d_open(struct file *file) @@ -564,6 +591,8 @@ static void device_run(void *prv) g2d_set_dst_addr(dev, vb2_dma_contig_plane_dma_addr(dst, 0)); g2d_set_rop4(dev, ctx-rop); +g2d_set_flip(dev, ctx-hflip | ctx-vflip); +

RE: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Kamil Debski
Hi Laurent and Sachin, Thanks for the patch and for your comments. From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 30 January 2012 13:12 Hi Sashin, Thanks for the patch. On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
Hi Laurent, Sylwester and Kamil, Thank you for your comments and suggestions. I will re-send the patch with the following 2 changes: 1. Error checking done only once at the end of the init call. 2. Modification in switch case as suggested by Kamil. Regards Sachin On 30 January 2012 19:09,