RE: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi All, Please follow v5 of this patch for the latest and ignore this patch. Sorry for the noise. Raj > -Original Message- > From: Mani, Rajmohan > Sent: Thursday, May 25, 2017 6:50 PM > To: linux-media@vger.kernel.org > Cc: mche...@kernel.org; hverk...@xs4all.nl; tf...@chromium.org; >

RE: [PATCH] dw9714: Initial driver for dw9714 VCM

ject: Re: [PATCH] dw9714: Initial driver for dw9714 VCM > > Hi Rajmohan, > > A few comments below... > > On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com > wrote: > > From: Rajmohan Mani <rajmohan.m...@intel.com> > > > > DW9714

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

On Tue, May 9, 2017 at 9:22 PM, Tomasz Figa wrote: > +Rafael, Kevin and Ulf, > > On Tue, May 9, 2017 at 8:16 PM, Sakari Ailus wrote: >> Hi Tomasz, >> >> On Tue, May 09, 2017 at 07:38:26PM +0800, Tomasz Figa wrote: >>> On Tue, May 9, 2017 at 6:40 PM,

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

+Rafael, Kevin and Ulf, On Tue, May 9, 2017 at 8:16 PM, Sakari Ailus wrote: > Hi Tomasz, > > On Tue, May 09, 2017 at 07:38:26PM +0800, Tomasz Figa wrote: >> On Tue, May 9, 2017 at 6:40 PM, Sakari Ailus wrote: >> > Hi Tomasz, >> > >> > On Tue, May 09,

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Tomasz, On Tue, May 09, 2017 at 07:38:26PM +0800, Tomasz Figa wrote: > On Tue, May 9, 2017 at 6:40 PM, Sakari Ailus wrote: > > Hi Tomasz, > > > > On Tue, May 09, 2017 at 04:30:40PM +0800, Tomasz Figa wrote: > >> Hi Sakari, > >> > >> On Tue, May 9, 2017 at 4:55 AM, Sakari

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

On Tue, May 9, 2017 at 6:40 PM, Sakari Ailus wrote: > Hi Tomasz, > > On Tue, May 09, 2017 at 04:30:40PM +0800, Tomasz Figa wrote: >> Hi Sakari, >> >> On Tue, May 9, 2017 at 4:55 AM, Sakari Ailus wrote: >> > Hi Rajmohan, >> > >> > A few comments below...

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Tomasz, On Tue, May 09, 2017 at 04:30:40PM +0800, Tomasz Figa wrote: > Hi Sakari, > > On Tue, May 9, 2017 at 4:55 AM, Sakari Ailus wrote: > > Hi Rajmohan, > > > > A few comments below... > > > > On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com wrote: >

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Sakari, On Tue, May 9, 2017 at 4:55 AM, Sakari Ailus wrote: > Hi Rajmohan, > > A few comments below... > > On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com wrote: [snip] >> + rval = v4l2_async_register_subdev(_dev->sd); >> + if (rval < 0) >> +

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Rajmohan, A few comments below... On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com wrote: > From: Rajmohan Mani > > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides

RE: [PATCH] dw9714: Initial driver for dw9714 VCM

m>; linux- > me...@vger.kernel.org; mche...@kernel.org > Subject: Re: [PATCH] dw9714: Initial driver for dw9714 VCM > > Hi Rajmohan, > > Thanks for the patch! > > A quick code review: > > On 05/07/2017 01:33 PM, rajmohan.m...@intel.com wrote: > > From: Rajmohan Mani &l

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Rajmohan, Thanks for the patch! A quick code review: On 05/07/2017 01:33 PM, rajmohan.m...@intel.com wrote: > From: Rajmohan Mani > > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides