Hi Hyungwoo,
Thanks for the patch. Please see my comments below.
On Tue, May 23, 2017 at 04:58:28PM -0700, Hyungwoo Yang wrote:
> This patch adds driver for Omnivision's ov13858
> sensor, the driver supports following features:
>
> - manual exposure/analog gain
> - two link frequencies
> - media
Hi Hyungwoo,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.12-rc2 next-20170524]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hyungwoo-Yang/i2c-add-support-for-O
Hi Hyungwoo,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.12-rc2 next-20170524]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hyungwoo-Yang/i2c-add-support-for-O
Hi Hyungwoo,
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.12-rc2 next-20170524]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hyungwoo-Yang/i2c-add-support-f
.intel.com; Zheng, Jian Xu
Subject: Re: [PATCH 1/1] [media] i2c: add support for OV13858 sensor
> Hi Hyungwoo,
>
> Thanks for the patch. Please see my comments below.
>
> On Tue, May 23, 2017 at 04:58:28PM -0700, Hyungwoo Yang wrote:
> > This patch adds driver for Omnivisi
Hi Hyungwoo,
On Wed, May 24, 2017 at 11:13:50PM +, Yang, Hyungwoo wrote:
...
> > > +static inline int ov13858_write_reg_list(struct ov13858 *ov13858,
> >
> > I'd drop inline.
>
> if it's not mandatory for upstream, I prefer to keep inline for people who
> want to port this with a not-good-co
Hi Sakari,
I've submitted V2 yesterday. If possible, can you review that one also ?
I'm learning many things from your review comments.
I think in V2, I've addressed most of comments except raw bayer format.
For ray bayer format, for now, I intentionally don't support crop since it
requires mor
On Fri, May 26, 2017 at 10:53:30PM +, Yang, Hyungwoo wrote:
> Hi Sakari,
>
> I've submitted V2 yesterday. If possible, can you review that one also ?
> I'm learning many things from your review comments.
>
> I think in V2, I've addressed most of comments except raw bayer format.
>
> For ray
> Subject: Re: [PATCH 1/1] [media] i2c: add support for OV13858 sensor
>
> On Fri, May 26, 2017 at 10:53:30PM +, Yang, Hyungwoo wrote:
> > Hi Sakari,
> >
> > I've submitted V2 yesterday. If possible, can you review that one also ?
> > I'm learning man
