Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Hans Verkuil
On Fri September 28 2012 15:47:20 Albert Wang wrote: > From: Libin Yang > > This patch adds the support of Soc Camera on marvell-ccic mcam-core. > The Soc Camera mode does not compatible with current mode. > Only one mode can be used at one time. > > To use Soc Camera, CONFIG_VIDEO_MMP_SOC_CAMER

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Albert Wang
Hi, Hans Thank you for reviewing the patches! >>On Fri September 28 2012 15:47:20 Albert Wang wrote: >> >> This patch adds the support of Soc Camera on marvell-ccic mcam-core. >> The Soc Camera mode does not compatible with current mode. >> Only one mode can be used at one time. >> >> To use So

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Sylwester Nawrocki
Hi, On 09/28/2012 08:37 PM, Albert Wang wrote: >>> + ret = v4l2_subdev_call(sd, core, g_chip_ident,&id); > >> Yuck. Don't abuse this. g_chip_ident is for debugging purposes only. > > Yes, can remove it. > >>> + if (ret< 0) { >>> + cam_err(mcam, "%s %d\n", __func__, __LINE__); >>>

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-29 Thread Jonathan Corbet
On Fri, 28 Sep 2012 21:47:20 +0800 Albert Wang wrote: > This patch adds the support of Soc Camera on marvell-ccic mcam-core. > The Soc Camera mode does not compatible with current mode. > Only one mode can be used at one time. > > To use Soc Camera, CONFIG_VIDEO_MMP_SOC_CAMERA should be defined.

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-29 Thread Guennadi Liakhovetski
On Sat, 29 Sep 2012, Jonathan Corbet wrote: > On Fri, 28 Sep 2012 21:47:20 +0800 > Albert Wang wrote: > > > This patch adds the support of Soc Camera on marvell-ccic mcam-core. > > The Soc Camera mode does not compatible with current mode. > > Only one mode can be used at one time. > > > > To u

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-30 Thread Jonathan Corbet
On Sat, 29 Sep 2012 13:40:41 -0600 Jonathan Corbet wrote: > I'm glad this work is being done, but I have some high-level grumbles > to start with. I was thinking on this over the weekend, and I realized that my response may have been a bit too short and grumpy. So I wanted to add one little thi

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-10-05 Thread Albert Wang
org; Libin Yang >Subject: Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on >marvell-ccic mcam-core > >On Fri, 28 Sep 2012 21:47:20 +0800 >Albert Wang wrote: > >> This patch adds the support of Soc Camera on marvell-ccic mcam-core. >> The Soc Camera mode d

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-10-05 Thread Albert Wang
>-Original Message- >From: Jonathan Corbet [mailto:cor...@lwn.net] >Sent: Monday, 01 October, 2012 05:10 >To: Albert Wang >Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang >Subject: Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-10-05 Thread Albert Wang
>-Original Message- >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] >Sent: Sunday, 30 September, 2012 07:31 >To: Jonathan Corbet >Cc: Albert Wang; linux-media@vger.kernel.org; Libin Yang >Subject: Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera s

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-10-15 Thread Albert Wang
Hi, Guennadi >-Original Message- >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] >Sent: Sunday, 30 September, 2012 07:31 >To: Jonathan Corbet >Cc: Albert Wang; linux-media@vger.kernel.org; Libin Yang >Subject: Re: [PATCH 2/4] [media] marvell-ccic: core: add

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-10-15 Thread Guennadi Liakhovetski
er.kernel.org; Libin Yang > >Subject: Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support > >on > >marvell-ccic mcam-core > > > >On Sat, 29 Sep 2012, Jonathan Corbet wrote: > > > >> On Fri, 28 Sep 2012 21:47:20 +0800 > >> Albert Wa