Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Tomasz Figa
May 09, 2017 4:44 PM >> To: Mani, Rajmohan <rajmohan.m...@intel.com> >> Cc: linux-media@vger.kernel.org; mche...@kernel.org; Hans Verkuil >> <hverk...@xs4all.nl> >> Subject: Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM >> >> Hi Rajmohan, >> >

RE: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Mani, Rajmohan
nel.org; Hans Verkuil > <hverk...@xs4all.nl> > Subject: Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM > > Hi Rajmohan, > > Some comments below. > > On Mon, May 8, 2017 at 10:36 PM, Rajmohan Mani > <rajmohan.m...@intel.com> wrote: > > DW9714 is

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Sakari Ailus
Hi Tomasz, On Tue, May 09, 2017 at 04:44:13PM +0800, Tomasz Figa wrote: ... > > +/* This function sets the vcm position, so it consumes least current */ > > +static int dw9714_suspend(struct device *dev) > > +{ > > + struct i2c_client *client = to_i2c_client(dev); > > + struct

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
Hi Rajmohan, Some comments below. On Mon, May 8, 2017 at 10:36 PM, Rajmohan Mani wrote: > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the desired focus. > >

RE: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Mani, Rajmohan
Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Tuesday, May 09, 2017 4:56 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-media@vger.kernel.org; mche...@kernel.org; hverk...@xs4all.nl > Subject: Re: [PATCH v2

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-08 Thread Sakari Ailus
On Mon, May 08, 2017 at 07:36:48AM -0700, Rajmohan Mani wrote: > + dev_dbg(dev, "%s ret = %d\n", __func__, ret); Please remove such debug prints. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk