Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-27 Thread Guennadi Liakhovetski
On Fri, 27 May 2011, javier Martin wrote: > On 25 May 2011 11:43, Laurent Pinchart > wrote: > > Hi Javier, > > > > On Wednesday 25 May 2011 11:41:42 javier Martin wrote: > >> Hi, > >> thank you for the review, I agree with you on all the suggested > >> changes except on this one: > >> > >> On 25

Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-27 Thread javier Martin
On 25 May 2011 11:43, Laurent Pinchart wrote: > Hi Javier, > > On Wednesday 25 May 2011 11:41:42 javier Martin wrote: >> Hi, >> thank you for the review, I agree with you on all the suggested >> changes except on this one: >> >> On 25 May 2011 10:05, Laurent Pinchart wrote: >> > On Tuesday 24 May

Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-25 Thread Laurent Pinchart
Hi Javier, On Wednesday 25 May 2011 11:41:42 javier Martin wrote: > Hi, > thank you for the review, I agree with you on all the suggested > changes except on this one: > > On 25 May 2011 10:05, Laurent Pinchart wrote: > > On Tuesday 24 May 2011 16:30:43 Javier Martin wrote: > >> This RFC includes

Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-25 Thread javier Martin
Hi, thank you for the review, I agree with you on all the suggested changes except on this one: On 25 May 2011 10:05, Laurent Pinchart wrote: > Hi Javier, > > Thanks for the patch. Here's a review of the power handling code. > > On Tuesday 24 May 2011 16:30:43 Javier Martin wrote: >> This RFC inc

Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-25 Thread Laurent Pinchart
Hi Javier, Thanks for the patch. Here's a review of the power handling code. On Tuesday 24 May 2011 16:30:43 Javier Martin wrote: > This RFC includes a power management implementation that causes > the sensor to show images with horizontal artifacts (usually > monochrome lines that appear on the