Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Hans Verkuil
Hi Daniel, Looks good for the most part, but I have two comments, see below... On 03/16/2014 11:33 AM, Daniel Glöckner wrote: > This patch adds support for the PCI-8604PW card equipped with four 878A. > It is unknown who the manufacturer of this card is and no drivers were > available during deve

Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Daniel Glöckner
Hi Hans, On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote: > > + switch (state) { > > + case 1: > > + case 5: > > + case 6: > > + case 4: > > + pr_debug("PCI-8604PW in state %i, toggling pin\n", > > +

Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Hans Verkuil
On 03/17/2014 12:59 PM, Daniel Glöckner wrote: > Hi Hans, > > On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote: >>> + switch (state) { >>> + case 1: >>> + case 5: >>> + case 6: >>> + case 4: >>> + pr_debug("PCI-8604PW