Re: [PATCH 1/5] mxl5007t: fix buggy register read

2013-04-09 Thread Antti Palosaari
On 04/10/2013 04:38 AM, Devin Heitmueller wrote: On Tue, Apr 9, 2013 at 8:45 PM, Antti Palosaari wrote: Yes, most devices do that, but not all! MxL5007t has a special register for setting register to read. Look the code and you could see it easily. It was over year ago I fixed it... That soun

Re: [PATCH 1/5] mxl5007t: fix buggy register read

2013-04-09 Thread Devin Heitmueller
On Tue, Apr 9, 2013 at 8:45 PM, Antti Palosaari wrote: > Yes, most devices do that, but not all! > MxL5007t has a special register for setting register to read. Look the code > and you could see it easily. It was over year ago I fixed it... That sounds kind of insane, but I haven't looked at the

Re: [PATCH 1/5] mxl5007t: fix buggy register read

2013-04-09 Thread Antti Palosaari
On 04/10/2013 03:20 AM, Devin Heitmueller wrote: On Tue, Apr 9, 2013 at 7:53 PM, Antti Palosaari wrote: Chip uses WRITE + STOP + READ + STOP sequence for I2C register read. Driver was using REPEATED START condition which makes it failing if I2C adapter was implemented correctly. Add use_broken

Re: [PATCH 1/5] mxl5007t: fix buggy register read

2013-04-09 Thread Devin Heitmueller
On Tue, Apr 9, 2013 at 7:53 PM, Antti Palosaari wrote: > Chip uses WRITE + STOP + READ + STOP sequence for I2C register read. > Driver was using REPEATED START condition which makes it failing if > I2C adapter was implemented correctly. > > Add use_broken_read_reg_intentionally option to keep old