Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-08-25 Thread Maxime Ripard
Hi Laurent, I've removed the comments I'll take into account On Mon, Aug 07, 2017 at 11:42:01PM +0300, Laurent Pinchart wrote: > > + csi2rx_reset(csi2rx); > > + > > + // TODO: modify the mapping of the DPHY lanes? > > The mapping should be read from DT and applied here. As far as I understa

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-08-25 Thread Maxime Ripard
Hi Benoit, On Mon, Aug 07, 2017 at 02:24:24PM -0500, Benoit Parrot wrote: > > +#define CSI2RX_STREAMS_MAX 4 > > + > > Just to confirm here that "streams" in this case are equivalent to > "Virtual Channel", correct? Kind of, yes, but it's a bit more complicated than that. The streams are the outp

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-08-07 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Thursday 20 Jul 2017 11:23:02 Maxime Ripard wrote: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes, >

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-08-07 Thread Benoit Parrot
Maxime Ripard wrote on Thu [2017-Jul-20 11:23:02 +0200]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes, > or without any D-PHY. The curren

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-07-22 Thread kbuild test robot
Hi Maxime, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/media-v4l-Add-support-f