Re: [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

2017-06-18 Thread Sakari Ailus
Hi Sylwester, On Sun, Jun 18, 2017 at 10:53:48PM +0200, Sylwester Nawrocki wrote: > >> + */ > >> +static int v4l_g_selection(const struct v4l2_ioctl_ops *ops, > >> + struct file *file, void *fh, void *arg) > >> +{ > >> + struct v4l2_selection *p = arg; > >> + u32 old_type = p

Re: [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

2017-06-18 Thread Sylwester Nawrocki
Hi, On 06/16/2017 02:58 PM, Sakari Ailus wrote: > Hi Hans, > > Cc Sylwester and Marek as well. > > On Mon, May 08, 2017 at 04:35:05PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The type field in struct v4l2_selection is supposed to never use the >> _MPLANE variants. E.g. if the driv

Re: [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

2017-06-16 Thread Sakari Ailus
Hi Hans, Cc Sylwester and Marek as well. On Mon, May 08, 2017 at 04:35:05PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > The type field in struct v4l2_selection is supposed to never use the > _MPLANE variants. E.g. if the driver supports > V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > then user