Re: as3645a flash userland interface

2017-09-18 Thread Sakari Ailus
Hi Jacek, On Tue, Sep 12, 2017 at 08:53:33PM +0200, Jacek Anaszewski wrote: > Hi Pavel, > > On 09/12/2017 12:36 PM, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > Note that

Re: as3645a flash userland interface

2017-09-14 Thread Sylwester Nawrocki
On 09/14/2017 01:53 PM, Pavel Machek wrote: On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote: On 09/14/2017 12:07 PM, Pavel Machek wrote: Isn't the V4L2 subdev/Media Controller API supposed to provide means for associating flash LEDs with camera sensors? You seem to be insisting on using

Re: as3645a flash userland interface

2017-09-14 Thread Pavel Machek
On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote: > On 09/14/2017 12:07 PM, Pavel Machek wrote: > >>Isn't the V4L2 subdev/Media Controller API supposed to provide means > >>for associating flash LEDs with camera sensors? You seem to be insisting > >>on using the sysfs leds interface for that,

Re: as3645a flash userland interface

2017-09-14 Thread Sylwester Nawrocki
On 09/14/2017 12:07 PM, Pavel Machek wrote: Isn't the V4L2 subdev/Media Controller API supposed to provide means for associating flash LEDs with camera sensors? You seem to be insisting on using the sysfs leds interface for that, which is not a primary interface for camera flash AFAICT. > a)

Re: as3645a flash userland interface

2017-09-14 Thread Sakari Ailus
Hi Pavel and others, On 09/14/17 13:07, Pavel Machek wrote: > Hi! > >> What directory are the flash controls in? >> >> /sys/class/leds/led-controller:flash ? >> >> Could we arrange for something less generic, like >> >> /sys/class/leds/main-camera:flash ? > >

Re: as3645a flash userland interface

2017-09-14 Thread Pavel Machek
Hi! > What directory are the flash controls in? > > /sys/class/leds/led-controller:flash ? > > Could we arrange for something less generic, like > > /sys/class/leds/main-camera:flash ? > >>> > >>>I'd rather avoid overcomplicating this. LED class device name pattern

Re: as3645a flash userland interface

2017-09-14 Thread Sylwester Nawrocki
Hi, On 09/13/2017 07:53 PM, Jacek Anaszewski wrote: On 09/12/2017 11:55 PM, Pavel Machek wrote: On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: On 09/12/2017 12:36 PM, Pavel Machek wrote: What directory are the flash controls in? /sys/class/leds/led-controller:flash ? Could we

Re: as3645a flash userland interface

2017-09-13 Thread Jacek Anaszewski
On 09/12/2017 11:55 PM, Pavel Machek wrote: > On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 09/12/2017 12:36 PM, Pavel Machek wrote: >>> Hi! >>> >>> There were some changes to as3645a flash controller. Before we have >>> stable interface we have to keep forever I want

Re: as3645a flash userland interface

2017-09-12 Thread Pavel Machek
On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: > Hi Pavel, > > On 09/12/2017 12:36 PM, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > Note that we have already two LED

Re: as3645a flash userland interface

2017-09-12 Thread Jacek Anaszewski
Hi Pavel, On 09/12/2017 12:36 PM, Pavel Machek wrote: > Hi! > > There were some changes to as3645a flash controller. Before we have > stable interface we have to keep forever I want to ask: Note that we have already two LED flash class drivers - leds-max77693 and leds-aat1290. They have been

Re: as3645a flash userland interface

2017-09-12 Thread Sakari Ailus
Ahoy! On Tue, Sep 12, 2017 at 01:40:51PM +0200, Pavel Machek wrote: > Hi! > > > On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > There were some changes to as3645a flash controller. Before we have > > > stable interface we have to keep forever I want to ask: >

Re: as3645a flash userland interface

2017-09-12 Thread Pavel Machek
Hi! > On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > > > What directory are the flash controls in? > > > >

Re: as3645a flash userland interface

2017-09-12 Thread Sakari Ailus
Hi Pavel, On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote: > Hi! > > There were some changes to as3645a flash controller. Before we have > stable interface we have to keep forever I want to ask: > > What directory are the flash controls in? > > /sys/class/leds/led-controller:flash

as3645a flash userland interface

2017-09-12 Thread Pavel Machek
Hi! There were some changes to as3645a flash controller. Before we have stable interface we have to keep forever I want to ask: What directory are the flash controls in? /sys/class/leds/led-controller:flash ? Could we arrange for something less generic, like /sys/class/leds/main-camera:flash