Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Antti Palosaari
On 06/16/2012 11:17 PM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 21:41 +0300, Antti Palosaari wrote: That is what you want to do: CALLBACK(struct dvb_usb_adapter *adap) { struct dvb_frontend *fe = adap->fe[adap->active_fe]; // now we have pointer to a

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Malcolm Priestley
On Sat, 2012-06-16 at 21:41 +0300, Antti Palosaari wrote: > > That is what you want to do: > > CALLBACK(struct dvb_usb_adapter *adap) > { >struct dvb_frontend *fe = adap->fe[adap->active_fe]; >// now we have pointer to adap and fe > } > > That is what I want

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Antti Palosaari
On 06/16/2012 09:12 PM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 18:52 +0300, Antti Palosaari wrote: On 06/16/2012 03:06 PM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 04:16 +0300, Antti Palosaari wrote: I did example for you, here you are :) On 06/16/2012 03:55 AM, Antti Palosaari

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Malcolm Priestley
On Sat, 2012-06-16 at 18:52 +0300, Antti Palosaari wrote: > On 06/16/2012 03:06 PM, Malcolm Priestley wrote: > > On Sat, 2012-06-16 at 04:16 +0300, Antti Palosaari wrote: > >> I did example for you, here you are :) > >> > >> On 06/16/2012 03:55 AM, Antti Palosaari wrote: > >>> On 06/16/2012 03:35 A

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Antti Palosaari
On 06/16/2012 03:06 PM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 04:16 +0300, Antti Palosaari wrote: I did example for you, here you are :) On 06/16/2012 03:55 AM, Antti Palosaari wrote: On 06/16/2012 03:35 AM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 01:54 +0300, Antti Palosaari

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-16 Thread Malcolm Priestley
On Sat, 2012-06-16 at 04:16 +0300, Antti Palosaari wrote: > I did example for you, here you are :) > > On 06/16/2012 03:55 AM, Antti Palosaari wrote: > > On 06/16/2012 03:35 AM, Malcolm Priestley wrote: > >> On Sat, 2012-06-16 at 01:54 +0300, Antti Palosaari wrote: > >>> Hello Malcolm, > >>> > >>>

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-15 Thread Antti Palosaari
I did example for you, here you are :) On 06/16/2012 03:55 AM, Antti Palosaari wrote: On 06/16/2012 03:35 AM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 01:54 +0300, Antti Palosaari wrote: Hello Malcolm, On 06/16/2012 01:11 AM, Malcolm Priestley wrote: Hi Antti You can't have dvb_usb_de

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-15 Thread Antti Palosaari
On 06/16/2012 03:35 AM, Malcolm Priestley wrote: On Sat, 2012-06-16 at 01:54 +0300, Antti Palosaari wrote: Hello Malcolm, On 06/16/2012 01:11 AM, Malcolm Priestley wrote: Hi Antti You can't have dvb_usb_device_properties as constant structure pointer. At run time it needs to be copied to a p

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-15 Thread Malcolm Priestley
On Sat, 2012-06-16 at 01:54 +0300, Antti Palosaari wrote: > Hello Malcolm, > > On 06/16/2012 01:11 AM, Malcolm Priestley wrote: > > Hi Antti > > > > You can't have dvb_usb_device_properties as constant structure pointer. > > > > At run time it needs to be copied to a private area. > > Having cons

Re: dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-15 Thread Antti Palosaari
Hello Malcolm, On 06/16/2012 01:11 AM, Malcolm Priestley wrote: Hi Antti You can't have dvb_usb_device_properties as constant structure pointer. At run time it needs to be copied to a private area. Having constant structure for properties was one of main idea of whole change. Earlier it cau

dvb_usb_v2: use pointers to properties[REGRESSION]

2012-06-15 Thread Malcolm Priestley
Hi Antti You can't have dvb_usb_device_properties as constant structure pointer. At run time it needs to be copied to a private area. Two or more devices of the same type on the system will be pointing to the same structure. Any changes they make to the structure will be common to all. Regards