Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

Hi Neil, I suspect that this patch will conflict with some patches that will be queued for 4.18 that also introduces new devices, well, for now I don't see these merged in the Lee's tree. Based on some reviews I got when I send a patch to this file ... 2018-05-15 17:29 GMT+02:00 Hans Verkuil

Re: [PATCH] media: dvb_ca_en50221: prevent using slot_info for Spectre attacs

Hi! I can't test it currently, but I reviewed it and it looks good. So you can add my Acked-by . BR, Jasmin

Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

On 05/15/2018 05:46 PM, Oliver Neukum wrote: > Am Dienstag, den 15.05.2018, 16:28 +0200 schrieb Hans Verkuil: >> On 05/15/18 15:07, Oliver Neukum wrote: >>> The premature free in the error path is blocked by V4L >>> refcounting, not USB refcounting. Thanks to >>> Ben Hutchings for review. >>> >>>

Re: [PATCH] media: dvb_ca_en50221: prevent using slot_info for Spectre attacs

Hi! I can't test it currently, but I reviewed it and it looks good. So you can add my Acked-by . BR, Jasmin

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

On Mon, May 14, 2018 at 07:35:03AM -0300, Mauro Carvalho Chehab wrote: > Hi Fabien, > > Em Mon, 14 May 2018 08:00:37 + > Fabien DESSENNE escreveu: > > > On 07/05/18 17:19, Mauro Carvalho Chehab wrote: > > > Em Mon, 07 May 2018 16:26:08 +0300 > > > Laurent Pinchart

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

ectre media issues I see smatch is reporting in linux-next-20180515: drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_error_inj_parse_line() warn: potential spectre issue 'pin->error_inj_args' drivers/media/dvb-core/dvb_ca_en50221.c:1479 dvb_ca_en50221_io_write() warn: potential spectre issue

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > instead of

Re: [PATCH v4 0/6] Asynchronous UVC

Em Tue, 27 Mar 2018 17:45:57 +0100 Kieran Bingham escreveu: > The Linux UVC driver has long provided adequate performance capabilities for > web-cams and low data rate video devices in Linux while resolutions were low. > > Modern USB cameras are now capable of

Re: [PATCH v4 0/6] Asynchronous UVC

Hi Mauro, On 15/05/18 20:22, Mauro Carvalho Chehab wrote: > Em Tue, 27 Mar 2018 17:45:57 +0100 > Kieran Bingham escreveu: > >> The Linux UVC driver has long provided adequate performance capabilities for >> web-cams and low data rate video devices in Linux while

[PATCH v2 0/2] IR decoding using BPF

The kernel IR decoders support the most widely used IR protocols, but there are many protocols which are not supported[1]. For example, the lirc-remotes[2] repo has over 2700 remotes, many of which are not supported by rc-core. There is a "long tail" of unsupported IR protocols. IR encoding is

[PATCH v2 2/2] bpf: add selftest for rawir_event type program

This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 55 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile

[PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report that the last key should be repeated. The bpf program can be attached to using the bpf(BPF_PROG_ATTACH) syscall; the target_fd must be the /dev/lircN

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

Signed-off-by: Sami Tolvanen <samitolva...@google.com> > >> Signed-off-by: Hans Verkuil <hansv...@cisco.com> > >> Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> > >> > > Thanks, Mauro. > > > > >

[PATCH] media: cec-pin-error-inj: avoid a false-positive Spectre detection

The current logic makes Smatch to false-detect a Spectre variant 1 vulnerability. The problem is that it initializes an u32 indirectly from user space input. After trying to write a fixup, after a while I realized that, in practice, this shouldn't be a problem, as an u32 is initialized from u8,

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

<samitolva...@google.com> > > > Signed-off-by: Hans Verkuil <hansv...@cisco.com> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> > > > > > Thanks, Mauro. > > > > > Possibly... There was an ancient bug in S

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Hi! > So, IMHO, entities should be described as: > > [entity entity1] > name = foo > function = bar I don't really think windows-style config file is suitable here, as we have more than two "nested blocks". What about something like this? Note that I'd only

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong For what it is worth (not an MFD expert): Acked-by: Hans Verkuil

Re: [PATCH v4 0/6] Asynchronous UVC

Em Tue, 15 May 2018 21:19:50 +0100 Kieran Bingham escreveu: > Hi Mauro, > > On 15/05/18 20:22, Mauro Carvalho Chehab wrote: > > Em Tue, 27 Mar 2018 17:45:57 +0100 > > Kieran Bingham escreveu: > > > >> The Linux UVC driver has

Re: [Intel-gfx] [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

Hi Neil, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc5 next-20180515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2 00/29] Venus updates

Hi Stanimir, On 05/15/18 09:58, Stanimir Varbanov wrote: > Hello, > > Here is v2 with following comments addressed: > > * reworked venus suspend 3xx and reuse it for 4xx. > * drop 10/28 patch from v1, i.e. call of session_continue when > buffer requirements are not sufficient. > * fixed

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

Hello, On Tuesday, 15 May 2018 10:30:28 EEST Fabien DESSENNE wrote: > On 14/05/18 12:39, Mauro Carvalho Chehab wrote: > > Em Mon, 14 May 2018 07:35:03 -0300 Mauro Carvalho Chehab escreveu: > >> Em Mon, 14 May 2018 08:00:37 + Fabien DESSENNE escreveu: > >>> On 07/05/18 17:19, Mauro Carvalho

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

On 15/05/2018 10:10, Hans Verkuil wrote: > On 05/15/18 09:25, Neil Armstrong wrote: >> Hi Hans, >> >> Thanks for the extensive review. >> >> On 15/05/2018 08:58, Hans Verkuil wrote: >>> On 05/15/2018 12:40 AM, Neil Armstrong wrote: The Chrome OS Embedded Controller can expose a CEC bus, this

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

On 05/15/18 10:28, Neil Armstrong wrote: > + int ret; > + > + cros_ec_cec = devm_kzalloc(>dev, sizeof(*cros_ec_cec), > +GFP_KERNEL); > + if (!cros_ec_cec) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, cros_ec_cec); >

Hello

Dear Friend, I am Mr. Joel TOURE,a banker by profession and I work with one of the largest bank here as the Group Managing Director/Chief Executive Officer. Meanwhile,I'm seriously in need of a partner then I decide to contact you believing that you can partner with me as I have opportunity to

[PATCH] adv7511: fix clearing of the CEC receive buffer

The CEC receive buffer was not always cleared correctly. The datasheet was a bit confusing since sometimes it mentioned that the bit in CEC register 0x4a had to be toggled, and sometimes it suggested it was a 'Clear-on-write' bit. But it really needs to be toggled. The patch also enables/disables

Re: [PATCHv13 01/28] v4l2-device.h: always expose mdev

Hi Hans, Thank you for the patch. On Thursday, 3 May 2018 17:52:51 EEST Hans Verkuil wrote: > From: Hans Verkuil > > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > But since we will need to pass the media_device to vb2 and the > control framework it

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed May 16 05:00:12 CEST 2018 media-tree git hash:2a5f2705c97625aa1a4e1dd4d584eaa05392e060 media_build

[PATCH] [media] MAINTAINERS: Update entry for Intel IPU3 cio2 driver

This patch adds three more maintainers to the IPU3 CIO2 driver. Signed-off-by: Yong Zhi --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 49003f77cedd..309d49a54db8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7150,6

Re: Donation

I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation:

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Tue, 15 May 2018 22:01:17 +0200 Pavel Machek escreveu: > Hi! > > > So, IMHO, entities should be described as: > > > > [entity entity1] > > name = foo > > function = bar > > I don't really think windows-style config file is suitable here, as we >

Re: [PATCH v6 04/17] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

Hi Jacob, Thank you for the patch. On Thursday, 8 March 2018 11:47:54 EEST Jacob Chen wrote: > From: Jacob Chen > > This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver Should this really be a subdev driver ? After a quick look at the code, the

<    1   2