Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
Hi Mauro, On Wednesday, 7 November 2018 21:53:20 EET Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 21:35:32 +0200 Laurent Pinchart escreveu: > > On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote: [snip] > >> I'm with Hans on that matter: better to start with an

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu: > Hi Hans, > > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > > >> On 11/06/18 14:12,

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Ezequiel Garcia
On Wed, 2018-11-07 at 09:05 +0100, Hans Verkuil wrote: > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > > > On 11/06/18 14:12, Laurent Pinchart wrote: > > > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
Hi Mauro, On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu: > > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > >> On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > >>> On Tuesday, 6 November

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Mauro Carvalho Chehab
Em Wed, 07 Nov 2018 21:35:32 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Wednesday, 7 November 2018 21:10:35 EET Mauro Carvalho Chehab wrote: > > Em Wed, 07 Nov 2018 12:06:55 +0200 Laurent Pinchart escreveu: > > > On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > > >>

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-07 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: > On 06/11/2018 23:13, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> We have both uvc_init_video() and uvc_video_init() calls which can be

Re: [PATCH] keytable: fix BPF protocol compilation on mips

2018-11-07 Thread Gregor Jasny
On 11/7/18 4:36 PM, Sean Young wrote: clang -idirafter /usr/local/include -idirafter +/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter +/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include +-I../../../include -target bpf -O2 -c grundig.c In file included from grundig.c:5: In file

Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2018-11-07 Thread Hyun Kwon
Hi Akinobu, Thanks for the patch. On Sun, 2018-11-04 at 05:11:10 -0800, Akinobu Mita wrote: > The fwnode_graph_get_next_endpoint() returns an 'endpoint' node pointer > with refcount incremented, and refcount of the passed as a previous > 'endpoint' node is decremented. > > So when iterating

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Shuah Khan
On 11/07/2018 12:10 PM, Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 12:06:55 +0200 > Laurent Pinchart escreveu: > >> Hi Hans, >> >> On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: >>> On 11/06/2018 08:58 PM, Laurent Pinchart wrote: On Tuesday, 6 November 2018

media: ov8856: Add support for OV8856 sensor

2018-11-07 Thread Ben Kao
This patch adds driver for Omnivision's ov8856 sensor, the driver supports following features: - manual exposure/gain(analog and digital) control support - two link frequencies - VBLANK/HBLANK support - test pattern support - media controller support - runtime pm support - supported resolutions

cron job: media_tree daily build: ERRORS

2018-11-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 8 05:00:11 CET 2018 media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708 media_build

RE: [PATCH] media: imx258: remove test pattern map from driver

2018-11-07 Thread Chen, JasonX Z
Hi Sakari Thanks for your feedback. I will update to the next patch. B.R., Jason -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Wednesday, November 7, 2018 6:32 PM To: Chen, JasonX Z Cc: linux-media@vger.kernel.org; Yeh, Andy ; tf...@chromium.org

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-07 Thread Tomasz Figa
Hi Nicolas, On Sat, Oct 27, 2018 at 6:38 PM Nicolas Dufresne wrote: > > Le lundi 22 octobre 2018 à 12:37 +0900, Tomasz Figa a écrit : > > Hi Philipp, > > > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > > > [...]

[PATCH] media: imx258: remove test pattern map from driver

2018-11-07 Thread jasonx . z . chen
From: "Chen, JasonX Z" change bayer order when using test pattern mode. remove test pattern mapping method Signed-off-by: Chen, JasonX Z --- drivers/media/i2c/imx258.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/media/i2c/imx258.c

Re: [PATCH] [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

2018-11-07 Thread Sakari Ailus
Hi Yong, On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote: > Also add V4L2_COLORSPACE_RAW to the colorspaces[]. > > Signed-off-by: Yong Zhi > --- > utils/media-ctl/libv4l2subdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/media-ctl/libv4l2subdev.c

[GIT PULL FOR v4.21] Various fixes

2018-11-07 Thread Hans Verkuil
Just one note: the "cec: keep track of outstanding transmits" is CC-ed to stable for v4.18 and up, but I prefer to wait until v4.21 before merging it to give it more test time. It is not something that happens in normal usage, so delaying this isn't a problem. Regards, Hans The

Re: [PATCH v7 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-07 Thread Sakari Ailus
On Fri, Aug 10, 2018 at 03:20:38PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Reviewed-by: Rob Herring > Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus - -- Sakari Ailus

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-07 Thread Sean Young
Hi Peter, On Tue, Nov 06, 2018 at 10:43:58PM +0100, Peter Seiderer wrote: > On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote: > > > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > > Copy from [1], needed by bpf.h. > > > > > > [1] > > >

Re: [PATCH v5 7/9] media: uvcvideo: Split uvc_video_enable into two

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:08, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> uvc_video_enable() is used both to start and stop the video stream >> object, however the single

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Hans Verkuil
Hi Rui, On 08/10/18 16:20, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media

Re: [PATCH] [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

2018-11-07 Thread Sakari Ailus
On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote: > Also add V4L2_COLORSPACE_RAW to the colorspaces[]. > > Signed-off-by: Yong Zhi > --- > utils/media-ctl/libv4l2subdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/media-ctl/libv4l2subdev.c

Re: [PATCH v5 6/9] media: uvcvideo: Move decode processing to process context

2018-11-07 Thread Kieran Bingham
On 06/11/2018 22:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:17 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Newer high definition cameras, and cameras with multiple lenses such as >> the range of stereo-vision cameras

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Laurent Pinchart
Hi Hans, On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: > On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > >> On 11/06/18 14:12, Laurent Pinchart wrote: > >>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus

Re: [PATCH] media: imx258: remove test pattern map from driver

2018-11-07 Thread Sakari Ailus
Hi Jason, Thanks for the patch. On Wed, Nov 07, 2018 at 03:22:23PM +0800, jasonx.z.c...@intel.com wrote: > From: "Chen, JasonX Z" > > Test Pattern mode be picked at HAL instead of driver. > do a FLIP when userspace use test pattern mode. > add entity_ops for validating imx258 link. > >

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Rui Miguel Silva
Hi Hans, On Wed 07 Nov 2018 at 09:58, Hans Verkuil wrote: Hi Rui, On 08/10/18 16:20, Rui Miguel Silva wrote: Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-07 Thread Sakari Ailus
Hi Philipp, On Tue, Nov 06, 2018 at 03:44:07PM +0100, Philipp Zabel wrote: > Hi Sakari, > > On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote: > [...] > > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh, > > v4l2_std_id std) > > > return

[PATCH v4l-utils] keytable: fix compilation warning

2018-11-07 Thread Sean Young
keytable.c: In function ‘parse_opt’: keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Sean Young --- utils/keytable/keytable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/keytable.c

[PATCH v2 v4l-utils] configure: build without BPF support in ir-keytable

2018-11-07 Thread Sean Young
It currently does not build on mips and some platforms do not have BPF support yet (risc-v, for example). Signed-off-by: Sean Young --- configure.ac | 17 + utils/keytable/Makefile.am | 7 --- utils/keytable/keytable.c | 5 - 3 files changed, 21

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Hans Verkuil
On 11/06/2018 08:58 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: >> On 11/06/18 14:12, Laurent Pinchart wrote: >>> On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil

Re: [PATCH v5 9/9] media: uvcvideo: Utilise for_each_uvc_urb iterator

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> A new iterator is available for processing UVC URB structures. This >> simplifies the processing

Re: [PATCH v4l-utils] keytable: fix compilation warning

2018-11-07 Thread Sakari Ailus
On Wed, Nov 07, 2018 at 12:02:14PM +, Sean Young wrote: > keytable.c: In function ‘parse_opt’: > keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function > [-Wuninitialized] > > Signed-off-by: Sean Young Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

[PATCH] vim2m: use cancel_delayed_work_sync instead of flush_schedule_work

2018-11-07 Thread Hans Verkuil
The use of flush_schedule_work() made no sense and caused a syzkaller error. Replace with the correct cancel_delayed_work_sync(). Signed-off-by: Hans Verkuil Reported-by: syzbot+69780d144754b8071...@syzkaller.appspotmail.com --- diff --git a/drivers/media/platform/vim2m.c

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-07 Thread Kieran Bingham
Hi Laurent, On 06/11/2018 23:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> We have both uvc_init_video() and uvc_video_init() calls which can be >> quite confusing to

[PATCH 1/1] v4l: uAPI doc: Simplify NATIVE_SIZE selection target documentation

2018-11-07 Thread Sakari Ailus
The NATIVE_SIZE target is documented for mem2mem devices but no driver has ever apparently used it. It may be never needed; remove it for now. Suggested-by: Hans Verkuil Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 7 +-- 1 file changed, 1

Re: [PATCH 1/1] v4l: uAPI doc: Simplify NATIVE_SIZE selection target documentation

2018-11-07 Thread Hans Verkuil
On 11/07/18 16:04, Sakari Ailus wrote: > The NATIVE_SIZE target is documented for mem2mem devices but no driver has > ever apparently used it. It may be never needed; remove it for now. > > Suggested-by: Hans Verkuil > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Thanks, Hans

[PATCH] keytable: fix BPF protocol compilation on mips

2018-11-07 Thread Sean Young
clang -idirafter /usr/local/include -idirafter +/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter +/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include +-I../../../include -target bpf -O2 -c grundig.c > In file included from grundig.c:5: > In file included from