cron job: media_tree daily build: OK

2018-09-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Sep 21 04:00:16 CEST 2018 media-tree git hash:985cdcb08a0488558d1005139596b64d73bee267 media_build

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
Ack, I will add more explanation into the code. On 09/19/2018 12:11 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > [snip] >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) >> +{ >> + int ret; >> + >> + ret =

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
On 09/18/2018 05:49 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. > Please see my

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
Ack. On 09/17/2018 07:34 PM, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update! A few more small comments, I think we're done after > these. > > On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony

Re: [PATCH] vidioc-dqevent.rst: clarify V4L2_EVENT_SRC_CH_RESOLUTION

2018-09-20 Thread Sakari Ailus
On Mon, Sep 17, 2018 at 01:37:18PM +0200, Hans Verkuil wrote: > Clarify that when you receive V4L2_EVENT_SOURCE_CHANGE with flag > V4L2_EVENT_SRC_CH_RESOLUTION set, and the new resolution appears > identical to the old resolution, then you still must restart the > streaming I/O. > >

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Ricardo Ribalda Delgado
HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

Re: [RESEND PATCH 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names

2018-09-20 Thread Sakari Ailus
Hi Sylwester, On Thu, Sep 20, 2018 at 11:01:26PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, > > On 09/16/2018 12:52 AM, Sakari Ailus wrote: > > v4l2_i2c_subdev_init() sets the name of the sub-devices (as well as > > entities) to what is fairly certainly known to be unique in the system, > >

Re: [PATCH v3 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-20 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday, 14 September 2018 14:03:01 EEST Sakari Ailus wrote: > The event subscriptions are added to the subscribed event list while > holding a spinlock, but that lock is subsequently released while still > accessing the subscription object. This makes it

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hi Sakari, On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > [snip] > > > > > + > > > +/* Digital gain control */ > > > +#define IMX208_REG_GR_DIGITAL_GAIN

Re: [RESEND PATCH 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names

2018-09-20 Thread Sylwester Nawrocki
Hi Sakari, On 09/16/2018 12:52 AM, Sakari Ailus wrote: > v4l2_i2c_subdev_init() sets the name of the sub-devices (as well as > entities) to what is fairly certainly known to be unique in the system, > even if there were more devices of the same kind. > > These drivers (m5mols, noon010pc30,

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hello, (CC'ing Helmut Grohne) On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > >>> +/* Digital gain control */

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Sakari Ailus
Hi Tomasz, On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define IMX208_REG_R_DIGITAL_GAIN

ad5820: Sorry for the invalid v3

2018-09-20 Thread Ricardo Ribalda Delgado
HI Sorry, I did not check the produced files before sending them with git send-email. It has been a long day. Please ignore v3 and use v4. I will write 100 times: I will check my patches before sending them to the mailing list Cheers -- Ricardo Ribalda

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Sylwester Nawrocki
On 09/20/2018 06:49 PM, Grant Grundler wrote: > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen >> wrote: >>> +/* Digital gain control */ >>> +#define IMX208_DGTL_GAIN_MIN 0 >>> +#define IMX208_DGTL_GAIN_MAX 4096 >>>

[PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-20 Thread Ricardo Ribalda Delgado
Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c |

Re: [PATCH v2 2/4] [media] ad5820: Add support for enable pin

2018-09-20 Thread Laurent Pinchart
Hi Ricardo, On Thursday, 20 September 2018 22:12:44 EEST Ricardo Ribalda Delgado wrote: > On Thu, Sep 20, 2018 at 9:08 PM Pavel Machek wrote: > > On Thu 2018-09-20 21:06:16, Ricardo Ribalda Delgado wrote: > >> On Thu, Sep 20, 2018 at 8:54 PM Pavel Machek wrote: > >>> On Thu 2018-09-20 20:45:52,

Re: [PATCH v2 2/4] [media] ad5820: Add support for enable pin

2018-09-20 Thread Laurent Pinchart
On Thursday, 20 September 2018 23:04:21 EEST Laurent Pinchart wrote: > Hi Ricardo, > > On Thursday, 20 September 2018 22:12:44 EEST Ricardo Ribalda Delgado wrote: > > On Thu, Sep 20, 2018 at 9:08 PM Pavel Machek wrote: > > > On Thu 2018-09-20 21:06:16, Ricardo Ribalda Delgado wrote: > > >> On

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-09-20 Thread Nicolas Dufresne
Le jeudi 20 septembre 2018 à 16:42 +0200, Hans Verkuil a écrit : > Some parts of the V4L2 API are awkward to use and I think it would be > a good idea to look at possible candidates for that. > > Examples are the ioctls that use struct v4l2_buffer: the multiplanar support > is > really horrible,

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-20 Thread Laurent Pinchart
Hi Mauro, On Thursday, 20 September 2018 17:44:53 EEST Mauro Carvalho Chehab wrote: > Em Fri, 07 Sep 2018 14:46:34 +0300 Laurent Pinchart escreveu: > > Hi Mauro, > > > > As maintainers should be held to the same level of obligations as > > developers, and to avoid demotivating reviewers, could

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Grant Grundler
[resend in plain text - sorry!] On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define

Re: [PATCH v3 1/2] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-09-20 Thread Philippe De Muyter
On Thu, Sep 20, 2018 at 05:11:50PM +0300, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday, 11 September 2018 20:06:32 EEST Philippe De Muyter wrote: > > add V4L2_FRMIVAL_TYPE_CONTINUOUS and V4L2_FRMIVAL_TYPE_STEPWISE for > > subdev's frame intervals in addition

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-20 Thread Mauro Carvalho Chehab
Em Fri, 07 Sep 2018 14:46:34 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > As maintainers should be held to the same level of obligations as developers, > and to avoid demotivating reviewers, could you handle comments you receive > before pushing your own patches to your tree ? There

[RFP] Which V4L2 ioctls could be replaced by better versions?

2018-09-20 Thread Hans Verkuil
Some parts of the V4L2 API are awkward to use and I think it would be a good idea to look at possible candidates for that. Examples are the ioctls that use struct v4l2_buffer: the multiplanar support is really horrible, and writing code to support both single and multiplanar is hard. We are also

Re: [PATCH v3 1/2] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-09-20 Thread Laurent Pinchart
Hi Philippe, Thank you for the patch. On Tuesday, 11 September 2018 20:06:32 EEST Philippe De Muyter wrote: > add V4L2_FRMIVAL_TYPE_CONTINUOUS and V4L2_FRMIVAL_TYPE_STEPWISE for > subdev's frame intervals in addition to implicit existing > V4L2_FRMIVAL_TYPE_DISCRETE type. This needs three new

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Tomasz Figa
[+Laurent and Sylwester] On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: [snip] > + > +/* Digital gain control */ > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > +#define IMX208_REG_R_DIGITAL_GAIN 0x0210 > +#define IMX208_REG_B_DIGITAL_GAIN 0x0212 > +#define