Re: PCI: make pci_restore_state return void

On Tuesday, November 30, 2010 04:43:26 pm Jon Mason wrote: pci_restore_state only ever returns 0, thus there is no benefit in having it return any value. Also, a large majority of the callers do not check the return code of pci_restore_state. Make the pci_restore_state a void return and

Re: [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC]

-by: Bjorn Helgaas bhelg...@google.com fs/proc/generic.c | 13 +++ include/linux/proc_fs.h |5 kernel/configs.c |2 +- kernel/profile.c |2 +- net/netfilter/xt_recent.c

Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

On Wed, May 14, 2014 at 08:49:43AM +0900, Gioh Kim wrote: Update some descriptions for API arguments and descriptions. Signed-off-by: Gioh Kim gioh@lge.com I applied this to my dma-api branch for v3.16, thanks! --- Documentation/dma-buf-sharing.txt | 14 -- 1 file

Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

On Tue, May 20, 2014 at 9:43 PM, Sumit Semwal sumit.sem...@linaro.org wrote: Hi Bjorn, On 21 May 2014 04:50, Bjorn Helgaas bhelg...@google.com wrote: On Wed, May 14, 2014 at 08:49:43AM +0900, Gioh Kim wrote: Update some descriptions for API arguments and descriptions. Signed-off-by: Gioh

Fwd: [Bug 98541] New: there exists a wrong return value of function meye_probe()

-- Forwarded message -- From: bugzilla-dae...@bugzilla.kernel.org Date: Mon, May 18, 2015 at 3:19 AM Subject: [Bug 98541] New: there exists a wrong return value of function meye_probe() To: bhelg...@google.com https://bugzilla.kernel.org/show_bug.cgi?id=98541 Bug

Re: [PATCH v2] pci: drop link_reset

On Tue, Jan 24, 2017 at 07:35:56PM +0200, Michael S. Tsirkin wrote: > No hardware seems to actually call link_reset, and > no driver implements it as more than a nop stub. > > This drops the mentions of the callback from everywhere. > It's dropped from the documentation as well, but > the doc

Re: kill off pci_enable_msi_{exact,range}

On Fri, Jan 13, 2017 at 09:05:53AM +0100, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 08:55:03AM +0100, Christoph Hellwig wrote: > > On Thu, Jan 12, 2017 at 03:29:00PM -0600, Bjorn Helgaas wrote: > > > Applied all three (with Tom's ack on the amd-xgbe patch) to pci/m

Re: kill off pci_enable_msi_{exact,range}

On Mon, Jan 09, 2017 at 09:37:37PM +0100, Christoph Hellwig wrote: > I had hope that we could kill these old interfaces of for 4.10-rc, > but as of today Linus tree still has two users: > > (1) the cobalt media driver, for which I sent a patch long time ago, > it got missed in the merge

Re: [PATCH 9/9] kernel-api.rst: fix a series of errors when parsing C files

de/linux/clk.h:134: WARNING: Inline emphasis start-string without > end-string. > ./ipc/util.c:477: ERROR: Unknown target name: "s". > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Bjorn Helgaas <bhelg...@google.com> # for d

Re: [PATCH 08/15] PCI: make device_type const

On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied to pci/misc for v4.14, thanks! > --- >

[PATCH] [media] netup_unidvb: use PCI_EXP_DEVCTL2_COMP_TIMEOUT macro

From: Bjorn Helgaas <bhelg...@google.com> Use the existing PCI_EXP_DEVCTL2_COMP_TIMEOUT macro instead of hard-coding the PCIe Completion Timeout Value mask. No functional change intended. Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- drivers/media/pci/netup_unidvb/netup_u

Re: [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse

On Tue, Jan 09, 2018 at 09:39:37PM +0100, Christoph Hellwig wrote: > Switch to a plain kzalloc instea of pci_zalloc_coherent to allocate > memory for the USB DMA. s/instea/instead/ > > Signed-off-by: Christoph Hellwig > --- > drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 13

Re: [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments

s/pci-dma-compat: remove handling of NULL pdev /PCI: Remove NULL device handling from DMA API/ On Tue, Jan 09, 2018 at 09:39:39PM +0100, Christoph Hellwig wrote: > Historically some ISA drivers used the old pci DMA API with a NULL pdev > argument, but these days this isn't used and not too

Re: [PATCH 3/4] tsi108_eth: use dma API properly

[+cc David, FYI, I plan to merge this via PCI along with the rest of Christoph's series] On Wed, Jan 10, 2018 at 07:03:21PM +0100, Christoph Hellwig wrote: > We need to pass a struct device to the dma API, even if some > architectures still support that for legacy reasons, and should not mix > it

Re: remove pci_dma_* abuses and workarounds V2

[+cc David] On Wed, Jan 10, 2018 at 07:03:18PM +0100, Christoph Hellwig wrote: > Back before the dawn of time pci_dma_* with a NULL pci_dev argument > was used for all kinds of things, e.g. dma mapping for non-PCI > devices. All this has been long removed, but it turns out we > still care for a